After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642034 - Use magnifier schemas from gsettings-desktop-schemas
Use magnifier schemas from gsettings-desktop-schemas
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: magnifier
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 642032
Blocks:
 
 
Reported: 2011-02-10 14:46 UTC by Thomas Wood
Modified: 2013-12-04 18:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (9.07 KB, patch)
2011-02-10 14:46 UTC, Thomas Wood 		committed Details | Review

Description Thomas Wood 2011-02-10 14:46:39 UTC 
Created attachment 180591 [details] [review]
Patch

Use magnifier schemas from gsettings-desktop-schemas so that they can be shared between Shell and the Universal Access settings panel.
Comment 1 Owen Taylor 2011-02-11 16:34:46 UTC 
Review of attachment 180591 [details] [review]:

Looks fine to me as far as I can tell.
Comment 2 Florian Müllner 2011-02-11 16:36:50 UTC 
Review of attachment 180591 [details] [review]:

I haven't actually tested it, but I doubt that you got the new schema name wrong ...

Looks good, though it would be nice to add a body to the commit message.

::: configure.ac
@@ +105,3 @@
 PKG_CHECK_MODULES(GVC, libpulse libpulse-mainloop-glib gobject-2.0)
 PKG_CHECK_MODULES(JS_TEST, clutter-x11-1.0 gjs-1.0 gobject-introspection-1.0 gtk+-3.0)
+PKG_CHECK_MODULES(DESKTOP_SCHEMAS, gsettings-desktop-schemas >= 0.1.7)

We effectively depend on gsettings-desktop-schemas already, so it might be a good idea to split this out in a separate patch and push it before the a11y one.
Comment 3 Thomas Wood 2011-02-11 17:02:32 UTC 
Pushed as cd56de8 - Move magnifier schemas to gsettings-desktop-schemas.