GNOME Bugzilla – Bug 642031
Adapting boxpointer to allow more precise placement of the arrow and match the calendar mockup
Last modified: 2011-02-16 15:20:32 UTC
Created attachment 180582 [details] [review] Add precision to arrow placement On the calendar mockup the arrow is somewhere about 20% of the top border, not at the begin, nor the end.
Created attachment 180583 [details] [review] Try to make the arrow match the mockup
Comment on attachment 180582 [details] [review] Add precision to arrow placement >+ ST_ALIGN_START = 0, >+ ST_ALIGN_MIDDLE = 50, >+ ST_ALIGN_END = 100 You should not do this. If we need precise alignment, then change the API to not take an StAlign value, and pass a float (not an integer). However, I am not sure that this really matters. I think the calendar would probably look fine with St.Align.MIDDLE. (It also seems to me that it's probably at 25% in the mockup; that is, it's centered over the the left half of the UI. I wonder, however, if this is just a remnant of an earlier design, in which the right half of the UI either didn't exist, or else could be shown and hidden.) (And as a random aside, part of the ugliness of the current state seems to be because the earlier arrow-drawing patches lost the constraint of "don't draw the arrow closer than 2*borderRadius from the edge if possible".)
Jon/Jakub: where exactly is the calendar supposed to float, relative to its panel button?
(In reply to comment #3) > Jon/Jakub: where exactly is the calendar supposed to float, relative to its > panel button? On IRC the other day, Jon said the left column is supposed to be centered under the date. (so, sort of like the old calendar, but with the second column added to the right)
Comment on attachment 180582 [details] [review] Add precision to arrow placement ok, so setPosition() should take a float, rather than an St.Align. and you should make sure the 0.0 and 1.0 positions are correct (starting at 2*borderRadius from the edge)
Comment on attachment 180583 [details] [review] Try to make the arrow match the mockup >+ PanelMenu.Button.prototype._init.call(this, 20); should be 0.25
Created attachment 180979 [details] [review] Add precision to arrow placement I think it's that
Created attachment 180980 [details] [review] Try to make the arrow match the mockup I don't think 0.25 is the right amount but …
25% looks right to me