After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641855 - out-of-tree plugins fail to compile [PATCH]
out-of-tree plugins fail to compile [PATCH]
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-02-08 18:09 UTC by Simon Wenner
Modified: 2011-02-26 02:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (597 bytes, patch)
2011-02-08 18:09 UTC, Simon Wenner 		accepted-commit_now Details | Review

Description Simon Wenner 2011-02-08 18:09:46 UTC 
Created attachment 180401 [details] [review]
proposed patch

Out-ot-tree plugins do not compile. I tried to compile a Vala plugin. totem.h includes "totem-playlist.h" but this file is not part of the installation files. In addition, the symbol "TotemCellRendererVideo" is undeclared.

The proposed patch removes the "totem-playlist.h" (seems to be unused in totem.h) and adds an include of "totem-cell-renderer-video.h" to totem.h.

An alternative would be to add "totem-cell-renderer-video.h" to the totem GIR file.
Comment 1 Bastien Nocera 2011-02-08 19:12:06 UTC 
Review of attachment 180401 [details] [review]:

This is probably good enough until we fix it properly.