After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641745 - menu separator fuzzy
menu separator fuzzy
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.91.x
Other All
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 689993 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-07 16:32 UTC by Jakub Steiner
Modified: 2012-12-19 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
separator thickness/sharpness dependent on font size (119.81 KB, image/png)
2011-02-07 16:42 UTC, Jakub Steiner 		  Details
preliminary patch (1.07 KB, patch)
2012-12-10 18:34 UTC, Allan Day 		accepted-commit_now Details | Review
screenshot of the patch in action (19.78 KB, image/png)
2012-12-10 18:35 UTC, Allan Day 		  Details
StDrawingArea: fix texture drawing (973 bytes, patch)
2012-12-19 14:19 UTC, Giovanni Campagna 		committed Details | Review
theme patch (1.11 KB, patch)
2012-12-19 15:44 UTC, Allan Day 		committed Details | Review

Description Jakub Steiner 2011-02-07 16:32:06 UTC 
I have noticed the rendering of the menu separator is dependent on the font size. For the default size, the 1px line is drawn precisely inbetween two pixel rows, making it fuzzy. If the font size is a pixel bigger or smaller, it becomes sharp and rendered precisely on 1 pixel row.

Can it be made so that the font size does not have effect on the sharpness?
Comment 1 Jakub Steiner 2011-02-07 16:37:11 UTC 
Things have actually changed since I played with the theme, the sharp state is 2px tall and the fuzzy state is 3px tall. But the core issue remains. Attaching screenshots illustrating the issue.
Comment 2 Jakub Steiner 2011-02-07 16:42:57 UTC 
Created attachment 180317 [details]
separator thickness/sharpness dependent on font size

14px font on the left - sharp separator (although I would have preferred it to be 1px rather than 2px)

13px font size on the right - fuzzy separator drawn on 3 pixel rows
Comment 3 Allan Day 2012-12-10 18:34:35 UTC 
Created attachment 231185 [details] [review]
preliminary patch

This fixes the separator appearance but loses necessary padding. padding-top and padding-bottom don't work.
Comment 4 Allan Day 2012-12-10 18:35:00 UTC 
Created attachment 231186 [details]
screenshot of the patch in action
Comment 5 Allan Day 2012-12-10 18:35:35 UTC 
*** Bug 689993 has been marked as a duplicate of this bug. ***
Comment 6 Jasper St. Pierre (not reading bugmail) 2012-12-10 19:10:52 UTC 
Review of attachment 231185 [details] [review]:

Sure.
Comment 7 Allan Day 2012-12-11 11:14:34 UTC 
(In reply to comment #6)
> Review of attachment 231185 [details] [review]:
> 
> Sure.

The spacing issue needs be fixed before this can land - there needs to be more vertical padding around the separators. Can you suggest a way of doing that?
Comment 8 Giovanni Campagna 2012-12-19 14:19:01 UTC 
Created attachment 231881 [details] [review]
StDrawingArea: fix texture drawing

cogl_rectangle() wants the four rectangle corners, not the size.

Allan, on top of this you can go wild with CSS :)
Comment 9 Rui Matos 2012-12-19 14:27:24 UTC 
Review of attachment 231881 [details] [review]:

Good catch.
Comment 10 Allan Day 2012-12-19 15:44:48 UTC 
Created attachment 231906 [details] [review]
theme patch

Awesome! Thanks Giovanni.