After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 641702 - Any options menu (such as Terrace) with more than four entries will fail to work
Any options menu (such as Terrace) with more than four entries will fail to work
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
2.32.x
Other All
: Normal major
: ---
Assigned To: gnome-games-aisleriot-maint
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-02-07 07:19 UTC by Kåre Fiedler Chrisitiansen
Modified: 2012-01-31 23:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that parses option values as decimal (631 bytes, patch)
2011-02-07 07:25 UTC, Kåre Fiedler Chrisitiansen 		none Details | Review

Description Kåre Fiedler Chrisitiansen 2011-02-07 07:19:20 UTC 
The game-specific Options-menu is internelly encoded with bitmask values. The first option has the value "Option1", the second "Option2", the third "Option4" and the fourth "Option8". This is all well and good. However, the fifth has "Option16", but when the value is parsed, it is expected to be hexadecimal, i.e. "Option10". The result is that what is supposed to be exclusive options can suddenly end up believing options 2,3 and 5 are simultanously on.

The fix is trivial and a patch for 2.32.1 is attached. The bug has been around since at least 2.26, making the last variations in Terrace unplayable (they simply worked as different variations). I haven't checked if "Terrace" is the only game with more than 4 options.
Comment 1 Kåre Fiedler Chrisitiansen 2011-02-07 07:25:10 UTC 
Created attachment 180269 [details] [review]
Patch that parses option values as decimal
Comment 2 Christian Persch 2011-02-07 16:55:29 UTC 
Fixed on master and gnome-2-32; thanks for the patch!
Comment 3 Robert Ancell 2012-01-31 23:31:39 UTC 
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component.  Apologies for the mass email!