Bug 641404 – [vp8enc] patch - use kbit/sec instead of bit/sec

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 641404 - [vp8enc] patch - use kbit/sec instead of bit/sec


Summary:	[vp8enc] patch - use kbit/sec instead of bit/sec

Attachments
patch vp8enc_bitrate.diff v1 (1.09 KB, patch) 2011-02-03 20:50 UTC, Oleksij Rempel	none	Details \| Review
patch vp8enc_bitrate.diff v2 (1.47 KB, patch) 2011-02-04 07:46 UTC, Oleksij Rempel	none	Details \| Review
patch vp8enc_bitrate.diff v3 (494 bytes, patch) 2011-02-04 08:05 UTC, Oleksij Rempel	none	Details \| Review
Add-description-for-bitrate-units.patch (861 bytes, patch) 2011-02-04 08:10 UTC, Oleksij Rempel	none	Details \| Review

Description Oleksij Rempel 2011-02-03 20:50:09 UTC

Created attachment 180019 [details] [review]
patch vp8enc_bitrate.diff v1

Use kbit/sec for bitrate, insted of bit/sec. Same as theoraenc and x264enc

Comment 1 Oleksij Rempel 2011-02-04 07:46:57 UTC

Created attachment 180044 [details] [review]
patch vp8enc_bitrate.diff v2

Comment 2 David Schleef 2011-02-04 08:03:23 UTC

Bit rate properties are supposed to be in bits/sec.  theoraenc is kbits/sec because of ABI reasons, and will be changed in 0.11.

Comment 3 Oleksij Rempel 2011-02-04 08:05:31 UTC

Created attachment 180046 [details] [review]
patch vp8enc_bitrate.diff v3

add explicit description for units

Comment 4 Oleksij Rempel 2011-02-04 08:10:13 UTC

Created attachment 180047 [details] [review]
Add-description-for-bitrate-units.patch

git ready

Comment 5 David Schleef 2011-02-04 08:24:44 UTC

Applied, slightly modified.