GNOME Bugzilla – Bug 641092
Rating data for currently playing track doesn't always report correctly over DBus
Last modified: 2011-02-01 00:36:04 UTC
I'm running version 1.9.2 of Banshee. Playing a song then changing the rating while that song is still playing doesn't always update the rating that gets reported over DBus. I noticed this while using CoverGloobus to control Banshee. If I changed the rating in Banshee, the update wasn't showing in CoverGloobus. Using "banshee --query-rating" shows exactly the same problem as well. Note that the rating *does* get updated in the database, as well as visually in the UI, so this seems to be a problem of not properly updating the data in the cache for the currently playing track. I originally commented on bug 623183, but there doesn't seem to be any response to that bug (possibly because it's so old). So, I'm adding more information here. Upon further investigation, I found this problem did not happen in specific cases: -changing the rating through the status icon correctly updated the rating -changing the rating through the "Edit Track Information" dialog also correctly updated the rating -changing the rating through the rating widget on the track context menu (right-clicking on the track, then setting the rating) also correctly updated the rating -changing the rating through DBus (such as using CoverGloobus to change the rating), also correctly changed the rating. What doesn't work is changing the rating by directly left-clicking on any rating widget within a TrackListView (Playlist, any Library view, Play Queue). Again, the database successfully updates, as does the UI, the rating reported over DBus is incorrectly the old rating (the cache doesn't get updated). I did even more investigation and think I have found a solution to the problem. All the methods of changing the rating that do work correctly contain some code that updates the currently playing track cache, and sends a notification of that update. Clicking on the rating widget within a TrackListView, does not do any such updates. So, I added a few lines of code to the value setting function that the widget appears to use when it is clicked.
Thanks for the tests! Could you copy your comment to bug 623183, I'm closing this one as its duplicate. *** This bug has been marked as a duplicate of bug 623183 ***