GNOME Bugzilla – Bug 641085
build: Use libedataserverui-3.0 instead of 1.2
Last modified: 2011-02-01 15:12:57 UTC
The release team has requested that gnome-shell uses the version of e-d-s included in GNOME 3 in the 3.0 release. Given that e-d-s is quite a beast and draws in additional dependencies, we probably want to postpone the switch as long as possible. Filing a patch anyway as a reminder.
Created attachment 179753 [details] [review] build: Use libedataserverui-3.0 instead of 1.2 The official GNOME moduleset builds evolution and e-d-s against GTK+-3, so libedataserverui-1.2 is no longer part of the release. Include e-d-s master in the moduleset and use it instead of the old stable version.
Just wanted to point out: Evolution 2.91.6 is already released and gtk+3-only, so unless this patch is merged, GNOME Shell will be broken with GNOME 2.91.6
Andreas is right, it's not possible to release GNOME 2.91.6 with GNOME Shell if it depends on an gnome2 evolution-data-server; if you don't want it in the shell special moduleset you'll need to add a configure switch to select the eds version.
Created attachment 179780 [details] [review] build: Default to libedataserverui-3.0 instead of 1.2 The official GNOME moduleset builds evolution and e-d-s against GTK+-3, so libedataserverui-1.2 is no longer part of the release. As GNOME Shell can actually be build with either version, prefer libedataserverui-3.0 if it is available and allow falling back to 1.2. if it isn't. (In reply to comment #3) > Andreas is right, it's not possible to release GNOME 2.91.6 with GNOME Shell if > it depends on an gnome2 evolution-data-server; if you don't want it in the > shell special moduleset you'll need to add a configure switch to select the eds > version. OK. I don't think a configure switch is needed, the attached patch just defaults to eds-3.0 if found and falls back to 1.2 otherwise. The gnome-shell-build-setup.sh script still mentions eds-1.2 as a dependency, but I doubt GNOME3 testers are using that script anyway.
A minor comment: The patch unnecessarily request evolution-data-server 2.91.90, which is not yet available in tarball form (and won't be for this GNOME test release). Asking for 2.91.6 should be perfectly fine.
Created attachment 179782 [details] [review] build: Default to libedataserverui-3.0 instead of 1.2 OK. I always follow git, so I don't have much of an idea about developement releases ...
Review of attachment 179782 [details] [review]: Look fine
Attachment 179782 [details] pushed as 703092f - build: Default to libedataserverui-3.0 instead of 1.2