Created attachment 179710 [details] [review]
delay: Adds new delay element

Adds a delay element to add offsets to buffers' timestamps

Just found this: http://gentrans.sourceforge.net/docs/head/gst-entrans-plugins/html/gst-entrans-plugins-shift.html

How do we want to proceed with this? Could you attach a new patch that merges the shift and delay elements, if necessary? IMHO something like timestampshift or timestampoffset would be a better name, delay suggests something else to me than what this element does.

bug 653601 has yet another such element for delaying audio streams.

Does shift work differently? I think it would be nice to also send an initial gap-buffer when delay>0 like done in bug #653601.

I think this can now be done simply by setting the offset property of GstPad?

Might still be useful to expose an element though, for discoverability and easy use in parse launch pipelines, and sending the GAP event and things like that.

Needs updating to 1.0.

I'd recommend to call it (timeshift|streamoffset) or something like that. In the audio world 'delay' is a ringbuffer based effect (with feedback) that produces echos and stuff like that.

Is this still needed in 1.0? As Tim said in comment 6 this should be possible with the offset property on pads nowadays.

I think the pad_offset is the right solution here (and more elegant). Lets close this.