After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640986 - Fix undefined symbol in libtotem-plparser-mini
Fix undefined symbol in libtotem-plparser-mini
Status: RESOLVED FIXED
Product: totem-pl-parser
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: totem-pl-parser-maint
totem-pl-parser-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-31 01:41 UTC by Yaakov Selkowitz
Modified: 2011-02-01 01:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix undefined symbol in libtotem-plparser-mini (881 bytes, patch)
2011-01-31 01:41 UTC, Yaakov Selkowitz
rejected Details | Review
Fix undefined symbol in libtotem-plparser-mini (1.32 KB, patch)
2011-02-01 01:21 UTC, Yaakov Selkowitz
none Details | Review

Description Yaakov Selkowitz 2011-01-31 01:41:22 UTC
With 2.32.2, linking libtotem-plparser-mini fails on PE platforms, as 
well as on Linux with -Wl,-z,defs, with an undefined reference to 
totem_pl_parser_is_videosite.  The videosite code is only included in 
the full library.
Comment 1 Yaakov Selkowitz 2011-01-31 01:41:25 UTC
Created attachment 179672 [details] [review]
Fix undefined symbol in libtotem-plparser-mini
Comment 2 Bastien Nocera 2011-01-31 12:15:56 UTC
That's wrong. totem_pl_parser_is_videosite() is supposed to be defined for both the normal library and the mini one, otherwise there's a loss in functionality.
Comment 3 Yaakov Selkowitz 2011-02-01 01:21:35 UTC
Created attachment 179758 [details] [review]
Fix undefined symbol in libtotem-plparser-mini

totem-pl-parser.c:totem_pl_parser_can_parse_from_uri() calls
totem_pl_parser_is_videosite(), which relies on libquvi.
Comment 4 Bastien Nocera 2011-02-01 01:30:29 UTC
Attachment 179758 [details] pushed as 0c63fa0 - Fix undefined symbol in libtotem-plparser-mini
Comment 5 Bastien Nocera 2011-02-01 01:33:55 UTC
commit 0c63fa02401190e0cfa1033f011722964b5031a2
Author: Yaakov Selkowitz <yselkowitz@users.sourceforge.net>
Date:   Mon Jan 31 19:12:56 2011 -0600

    Fix undefined symbol in libtotem-plparser-mini
    
    totem-pl-parser.c:totem_pl_parser_can_parse_from_uri() calls
    totem_pl_parser_is_videosite(), which relies on libquvi.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=640986