After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640963 - Simplify button handling
Simplify button handling
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: media-keys
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-30 18:53 UTC by Sjoerd Simons
Modified: 2011-03-14 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (4.97 KB, patch)
2011-01-30 18:54 UTC, Sjoerd Simons 		needs-work Details | Review

Description Sjoerd Simons 2011-01-30 18:53:13 UTC 
As requested on #637569, submitting the simplification part of my bugfix as a seperate (updated) patch.
Comment 1 Sjoerd Simons 2011-01-30 18:54:03 UTC 
Created attachment 179646 [details] [review]
proposed patch
Comment 2 Bastien Nocera 2011-02-15 16:22:26 UTC 
Review of attachment 179646 [details] [review]:

::: plugins/media-keys/gsd-media-keys-manager.c
@@ +646,3 @@
         /* FIXME: this is racy */
+        new_vol = old_vol = gvc_mixer_stream_get_volume (manager->priv->stream);
+        new_vol = old_muted = gvc_mixer_stream_get_is_muted (manager->priv->stream);

Huh, bug here.
Comment 3 Bastien Nocera 2011-03-02 18:28:06 UTC 
And it doesn't apply any more.
Comment 4 Bastien Nocera 2011-03-14 15:48:39 UTC 
commit 28e177c44438e77bc280a007e362999bef633566
Author: Sjoerd Simons <sjoerd@luon.net>
Date:   Mon Mar 14 15:48:01 2011 +0000

    media-keys: Simplify volume keys handling
    
    https://bugzilla.gnome.org/show_bug.cgi?id=640963