GNOME Bugzilla – Bug 640795
Between accelerator modifyer and letters need a word with separate this informations
Last modified: 2018-02-08 12:56:45 UTC
Dear Developers, Orca now spokening following style the accelerator keys: "Cut Control x Paste Control v" Better I think following form: "Cut Control Plus x Paste Control plus v Select all Control plus a New profile... Shift plus Control plus v" I doed the patch and will be attaching with next comment. The separator plus word I marked for translation, because I not want using normal + character between accelerator modifyer keys and letters. Attila
Created attachment 179488 [details] [review] First revision Please look this first revision. I add "plus" word and marking translation, this is will be separator word between shortcut and accelerator modifications. The patch working right both dialog controls and menues with have accelerator keys. I attaching next comment a patch with only change the separator word with + character, this advantage is not need adding a new string for translation. Attila
Created attachment 179489 [details] [review] Second revision This patch different only the separator word, the plus separator word simple replaced with + character, this situation not need marking translation this simbol. Attila
Hey Attila. Thanks for the patch. Personally I don't think we want to do this. I think Control x is easier to understand (and listen to) than Control Plus x. However, I see that you posted your bug and solution on the Orca list. If everyone chimes in to state that this is what the really want, I will reconsider my position on this.
Joanie, this is full fair, thank you the answer. If more people general not acceptable this modification, fair to not committing this fix. If the community partialy accepting this modification, I have got some ydea: For example not better if we using this method if the verbosity is setted verbose, and brief only sending now used original format? Or: Doing a setting with possible toggling this mode on/off? If this is the better method, need doing future a checkbox with speech page below the speak object mnemonics checkbox with presenting only if this checkbox are checked. Attila
Created attachment 179519 [details] [review] Third revision with possible toggling this mode Joanie, please review this revision. I created a new setting with src/orca/settings.py with toggling this separation mode on/off. The setting name is separateShortcutModifiers. If this setting is true, the new separation mode happening, and inserting plus word between modifier keys. Of course compatibility purpose keep this setting with false to not disturb users with not want using this new mode, if anybody want hear the acceleration modifiers and full shortcut modifiers with old known format, not need do anything. This method is acceptable your openion? If yes, need the translated plus word with separation, or only enough the + character? For example Espeak right spokening the + character too. Attila
Created attachment 185785 [details] [review] New revision of this function Dear Joanie, I attaching a new revision. This revision containing a checkbox for speech page, the users this way possible toggling on/off this function without need hand editing the user-settings.conf file. Of course, to prowide backward compatibility, the checkbox is default unchecked. Please review this patch. I think I am ready this function if you not found any errors. If my patch is full good, possible committing this revision with actual development branch? Attila