After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640768 - power menu issues
power menu issues
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 642482
Blocks:
 
 
Reported: 2011-01-27 22:14 UTC by William Jon McCann
Modified: 2011-03-03 21:20 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
Do not launch power statistics app from battery items (1.81 KB, patch)
2011-03-02 01:05 UTC, William Jon McCann
needs-work Details | Review
Do not launch power statistics app from battery items (2.41 KB, patch)
2011-03-02 22:52 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2011-01-27 22:14:17 UTC
* The icon in the battery menu item should be symbolic
 * The battery menu item should be insensitive and not launch the power statistics dialog
Comment 1 drago01 2011-01-28 13:15:26 UTC
(In reply to comment #0)

> * The battery menu item should be insensitive and not launch the power
> statistics dialog

From where should it be opened then? Should it end up being an app?
Comment 2 William Jon McCann 2011-02-27 20:18:15 UTC
We can probably add some of that information to the system info panel.  The rest is just geek stuff and someone can launch it from the command line or something.
Comment 3 Matthias Clasen 2011-02-27 22:19:06 UTC
We do have a symbolic icon now, but it still launches the statistics
Comment 4 William Jon McCann 2011-03-02 01:05:13 UTC
Created attachment 182230 [details] [review]
Do not launch power statistics app from battery items
Comment 5 Dan Winship 2011-03-02 13:15:03 UTC
Comment on attachment 182230 [details] [review]
Do not launch power statistics app from battery items

>+            this._batteryItem.actor.reactive = false;
>+            this._batteryItem.actor.can_focus = false;

This will never change now, so just set it when this._batteryItem is constructed in _init:

        this._batteryItem = new PopupMenu.PopupMenuItem('', { reactive: false });


>+                item.actor.reactive = false;
>+                item.actor.can_focus = false;

Likewise, change the super call in DeviceItem._init to:

        PopupMenu.PopupBaseMenuItem.prototype._init.call(this, { reactive: false });
Comment 6 William Jon McCann 2011-03-02 22:52:14 UTC
Created attachment 182311 [details] [review]
Do not launch power statistics app from battery items
Comment 7 André Klapper 2011-03-03 20:52:04 UTC
[Removing GNOME3.0 target as decided in release-team meeting on March 03, 2011. "nice-to-have" categorisation for GNOME3.0]