After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640494 - swipe-scrolling: Take threshold into account during drag
swipe-scrolling: Take threshold into account during drag
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-25 00:32 UTC by Florian Müllner
Modified: 2011-01-25 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
swipe-scrolling: Take threshold into account during drag (2.88 KB, patch)
2011-01-25 00:32 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-01-25 00:32:01 UTC 
See patch.
Comment 1 Florian Müllner 2011-01-25 00:32:04 UTC 
Created attachment 179258 [details] [review]
swipe-scrolling: Take threshold into account during drag

On button-release, a threshold is used to determine if the gesture
should be considered a click and thus ignored. While the drag is
active though, the controlled actor is dragged immediately. As a
result, dragging by a tiny amount does not trigger a snap back when
the action is interpreted as a click. As a fix, do not update the
dragged actor's position until the same threshold is passed.
Comment 2 Owen Taylor 2011-01-25 02:50:29 UTC 
Review of attachment 179258 [details] [review]:

I was worried that this would feel bad and take away from the immediacy of the gesture, but at least as far as I can tell with a trackpoint it's barely noticeable and the code makes sense.
Comment 3 Florian Müllner 2011-01-25 09:32:25 UTC 
Attachment 179258 [details] pushed as eb8fc73 - swipe-scrolling: Take threshold into account during drag