After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 640252 - Missing package definition in Gir
Missing package definition in Gir
Status: RESOLVED FIXED
Product: libpeas
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks: 622664
 
 
Reported: 2011-01-22 13:17 UTC by Michal Hruby
Modified: 2011-02-04 15:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (680 bytes, patch)
2011-01-22 13:45 UTC, Michal Hruby
committed Details | Review
Patch (1.68 KB, patch)
2011-01-25 00:19 UTC, Michal Hruby
none Details | Review
Patch (2.73 KB, patch)
2011-02-04 13:45 UTC, Michal Hruby
committed Details | Review

Description Michal Hruby 2011-01-22 13:17:17 UTC
Please add the "--pkg-export=libpeas-1.0" option to INTROSPECTION_SCANNER_ARGS (in libpeas/Makefile.am), to make it possible for the gir users to grab the cflags.

This will for example allow vala to compile source using libpeas using a simple "valac --pkg Peas-1.0 source.vala".
Comment 1 Ignacio Casal Quinteiro (nacho) 2011-01-22 13:33:30 UTC
Please provide a git format-patch for it so you get the credit for it.
Comment 2 Michal Hruby 2011-01-22 13:45:20 UTC
Created attachment 179036 [details] [review]
Patch
Comment 3 Ignacio Casal Quinteiro (nacho) 2011-01-22 19:16:27 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Ignacio Casal Quinteiro (nacho) 2011-01-24 23:07:58 UTC
I'm reopening this. See: http://git.gnome.org/browse/libpeas/commit/?id=0a139d6a61c032b14bcea4ed3291f7595b4ce71b for the reason. Please feel free to provide a patch that works. Also maybe this is a bug in the scanner, if so, feel free to file a bug in gobject-introspection and depend this bug on it.
Comment 5 Michal Hruby 2011-01-25 00:19:22 UTC
Created attachment 179256 [details] [review]
Patch

Perhaps this one will work fine.
Comment 6 Michal Hruby 2011-02-04 13:45:16 UTC
Created attachment 180078 [details] [review]
Patch

Updated patch, it also bumps required gobject-introspection version.
Comment 7 Ignacio Casal Quinteiro (nacho) 2011-02-04 13:51:20 UTC
Review of attachment 180078 [details] [review]:

This patch looks better to me
Comment 8 Steve Frécinaux 2011-02-04 15:07:52 UTC
This is fixed in master. Thanks!