After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639951 - keyboard: Fix infinite loop while selecting an xkb option
keyboard: Fix infinite loop while selecting an xkb option
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Keyboard
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-19 14:40 UTC by Arun Raghavan
Modified: 2011-01-19 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keyboard: Fix infinite loop while selecting an xkb option (911 bytes, patch)
2011-01-19 14:40 UTC, Arun Raghavan
none Details | Review
region: Fix infinite loop when selecting Xkb options (1.32 KB, patch)
2011-01-19 14:52 UTC, Bastien Nocera
committed Details | Review

Description Arun Raghavan 2011-01-19 14:40:24 UTC
This fixes a trivial bug that causes an infinite loop when you try to set more than one xkb option
Comment 1 Arun Raghavan 2011-01-19 14:40:28 UTC
Created attachment 178727 [details] [review]
keyboard: Fix infinite loop while selecting an xkb option
Comment 2 Bastien Nocera 2011-01-19 14:52:14 UTC
Created attachment 178729 [details] [review]
region: Fix infinite loop when selecting Xkb options

Spotted by Arun Raghavan <arun.raghavan@collabora.co.uk>
Comment 3 Bastien Nocera 2011-01-19 14:52:47 UTC
The old code was ugly ugly. Does the above fix the problem for you?
Comment 4 Arun Raghavan 2011-01-19 15:08:37 UTC
Thanks Bastien, it does fix the problem.
Comment 5 Bastien Nocera 2011-01-19 15:13:56 UTC
Attachment 178729 [details] pushed as 978ae12 - region: Fix infinite loop when selecting Xkb options