After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639897 - Missing translatable strings for the UI
Missing translatable strings for the UI
Status: RESOLVED FIXED
Product: libgda
Classification: Other
Component: general
4.2.x
Other Linux
: Normal normal
: ---
Assigned To: malerba
gnome-db Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-18 21:37 UTC by Bruno Brouard
Modified: 2011-01-22 16:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (47.35 KB, image/png)
2011-01-20 18:53 UTC, Bruno Brouard
Details
screenshot 2 (67.79 KB, image/png)
2011-01-20 18:55 UTC, Bruno Brouard
Details
screenshot 3 (49.34 KB, image/png)
2011-01-20 18:56 UTC, Bruno Brouard
Details

Description Bruno Brouard 2011-01-18 21:37:09 UTC
Tested with version 4.2.4 on ubuntu 10.10 :

Many translatable strings are not marked for translation, missing in POT file.

Some examples :
=============================================================
from line 490- of tools/browser/schema-browser/table-columns.c:490--- :

	/* Colum: Nullok */
	renderer = gtk_cell_renderer_toggle_new ();
	column = gtk_tree_view_column_new_with_attributes ("Not NULL?", renderer,
							   "active", COLUMN_NOTNULL, NULL);
	gtk_tree_view_append_column (GTK_TREE_VIEW (treeview), column);

	/* Colum: Default */
	renderer = gtk_cell_renderer_text_new ();
	column = gtk_tree_view_column_new_with_attributes ("Default value", renderer,
							   "text", COLUMN_DEFAULT, NULL);
	gtk_tree_view_append_column (GTK_TREE_VIEW (treeview), column);

	/* Colum: Details */
	renderer = gtk_cell_renderer_text_new ();
	column = gtk_tree_view_column_new_with_attributes ("Details", renderer,
							   "text", COLUMN_DETAILS, NULL);

==========================================================================
tools/browser/schema-browser/table-info.c:339:	

tmp = g_strdup_printf ("In schema '%s'", schema);

===========================================================================
All the strings in the following file :

providers/web/web_specs_dsn.xml.in:6:    
<parameter id="PATH" _name="Path to 
PHP script" _descr="The path of the script to use if service is not at the web server's root" gdatype="gchararray"/>


===========================================================================
libgda/sqlite/xml_embedded.h:177

"    <parameter id=\"DB_NAME\" name=\"Database name\" descr=\"The name of a database to use (without the .db)\" gdatype=\"gchararray\" nullok=\"FALSE\"/>\n"
"    <parameter id=\"DB_DIR\" name=\"Directory\" descr=\"Directory where the database file is stored\" gdatype=\"gchararray\" nullok=\"FALSE\" plugin=\"filesel:MODE=PICKFOLDER\"/>\n"
"    <parameter id=\"LOAD_GDA_FUNCTIONS\" name=\"Extra functions\" descr=\"Enable usage of some extra functions in SQL\" gdatype=\"gboolean\" nullok=\"TRUE\"/>\n"
"    <parameter id=\"FK\" name=\"With foreign keys\" descr=\"Enforce foreign keys\" gdatype=\"gboolean\" nullok=\"TRUE\"/>\n"
"  </parameters>\n"
"</data-set-spec>\0<?xml version=\"1.0\"?>\n"


AND finally, menus and toolbar are still in English though the messages are translated in the PO files
(see BUG https://bugzilla.gnome.org/show_bug.cgi?id=634737 which can be reopen):
===========================================================================
tools/browser/browser-window.c: line 274-304



Don't hesitate to ask for more information.

Sincerely

Bruno

GNOME French Team coordinator
Comment 1 malerba 2011-01-19 14:40:57 UTC
There is a partial correction in git/master: http://git.gnome.org/browse/libgda/commit/?id=d0688e562ffe371d3f11df23d74c96177a73846a

For the following files, the strings are already proposed for translation
* providers/web/web_specs_dsn.xml.in
* tools/browser/browser-window.c

For the libgda/sqlite/xml_embedded.h, it's more complicated because this string is a fallback string in case Libgda is not correctly installed, so I propose not to make it translatable as it should not be used by the end user anyway.
Comment 2 Bruno Brouard 2011-01-20 18:53:49 UTC
Created attachment 178871 [details]
screenshot
Comment 3 Bruno Brouard 2011-01-20 18:55:06 UTC
(In reply to comment #1)
> There is a partial correction in git/master:
> http://git.gnome.org/browse/libgda/commit/?id=d0688e562ffe371d3f11df23d74c96177a73846a
> 

Thank you for the previous corrections


> For the following files, the strings are already proposed for translation
> * providers/web/web_specs_dsn.xml.in
> * tools/browser/browser-window.c
> 

I think there is a mistake using gettext (I am not a programmer, i can't help you)

> For the libgda/sqlite/xml_embedded.h, it's more complicated because this string
> is a fallback string in case Libgda is not correctly installed, so I propose
> not to make it translatable as it should not be used by the end user anyway.

I attach 3 figures to show how and where the untranslated strings (freshly compiled with the git source) appear.

I tested with spanish mo file and it was the same result. 

Hope it will help you.

Bruno
Comment 4 Bruno Brouard 2011-01-20 18:55:56 UTC
Created attachment 178873 [details]
screenshot 2
Comment 5 Bruno Brouard 2011-01-20 18:56:54 UTC
Created attachment 178874 [details]
screenshot 3
Comment 6 malerba 2011-01-22 13:40:38 UTC
I've done some more corrections in git/master: http://git.gnome.org/browse/libgda/commit/?id=bb94b8821f3529b9de20153c7db52ba1a3b52fb6

Can you check it's now OK (I've also modified some French transations)?
Comment 7 Bruno Brouard 2011-01-22 16:29:54 UTC
(In reply to comment #6)
> I've done some more corrections in git/master:
> http://git.gnome.org/browse/libgda/commit/?id=bb94b8821f3529b9de20153c7db52ba1a3b52fb6
> 
> Can you check it's now OK (I've also modified some French transations)?

I just compiled and everything is ok now.

Thank you very much

Bruno

PS : about modified translation, you mean that :
you added new strings OR
you corrected some message (because you speak french) ?

I mark the bug as RESOLVED.
Comment 8 malerba 2011-01-22 16:55:27 UTC
About the French transations, I've corrected some messages marked as fuzzy (I'm French, from Toulouse).
Thanks for the bug report!