GNOME Bugzilla – Bug 639500
Crash when trying to open a note from a corrupted file
Last modified: 2011-06-25 17:58:45 UTC
Created attachment 178299 [details] [review] Correct exception handling when loading corrupted note files Tomboy crashes when it tries to open a damaged note file (which can happen, for example, after a power outage or kernel panic). As all note files are loaded at start-up this can lead to start-up crashes. The user is then obviously only informed that Tomboy has crashed and provided with no more information on how to access her notes. The attached patch handles System.IO.IOException in NoteManager.LoadNotes() and provides the user with information on the problem and which note is lost.
Created attachment 178303 [details] [review] Correct exception handling when trying to load files without read permissions The second patch deals in the same manner with the situation when a note file has insufficient permissions. However, this case is much less likely to happen in the wild, so this patch is not really important.
Comment on attachment 178299 [details] [review] Correct exception handling when loading corrupted note files Looks good thanks
Comment on attachment 178303 [details] [review] Correct exception handling when trying to load files without read permissions Nice, thanks!
commit 5770662522219349b6c38ac8f1774d474c9e72bf commit c9b2876607185380a39b2d93d367152184b3857b Thanks for the patches! These will show up in tomboy 1.7.1