GNOME Bugzilla – Bug 639019
Use theme colors for lines/row headers and cell selections
Last modified: 2011-01-09 01:02:55 UTC
Created attachment 177842 [details] screenshot comparing calc and gnumeric This is purely a cosmetic/aesthetic nitpick, and frankly, a minor one considering the rock-solid quality of gnumeric, but I thought I'd ask for it anyway. Calc has a pretty integration with the GTK theme's colors. If you use Clearlooks, the cell headers have a blue tint, selections have a blue tint, etc. Gnumeric does not integrate with the theme at all for this, and it looks a little bit less sexy. Considering that GNumeric is a better "native" GTK/GNOME application on all other fronts, it would be quite nice if there was some way for this to look even better-integrated. I don't know if gnumeric uses standard widgets or custom-made ones for the cell headers (and the cells) and how hard it would be to implement, but this would be nice to have.
Gnumerics, cell headers are theme-dependent. Nowhere in clearlooks can I find a blue gradient as in the row headers of Calc. As an aside: of course we are not using any widgets for the individual cell headers and cells. Can you imagine the performance hit that would entail?
I didn't mean the "glossy" effect per se, but rather the color. It's alright for the "not selected" header color (it does use the theme colors afaict), but the "selected" color (albeit using the theme) seems to be a bit off, because it doesn't match the theme's typical "selected" color. Well that, and the selection "rubber band" color too. I don't know what gnumeric currently uses, but the typical "selected" color in themes such as clearlooks/mist/industrial is blue, in the Ambiance theme it is orange, etc. I have peeked in /usr/share/themes/Clearlooks/gtk-2.0/gtkrc, and saw that bg[SELECTED] is perhas what we are looking for: it points to "selected_bg_color:#86ABD9" (which is blue).
If I understand the code in question right we currently use (with breaks, and other irrelevant code removed): case COL_ROW_NO_SELECTION: color = GO_COLOR_FROM_GDK (style->bg[GTK_STATE_ACTIVE]); font_color = GO_COLOR_FROM_GDK (style->fg[GTK_STATE_ACTIVE]); case COL_ROW_PARTIAL_SELECTION: color = GO_COLOR_FROM_GDK (style->dark[GTK_STATE_PRELIGHT]); font_color = GO_COLOR_FROM_GDK (style->fg[GTK_STATE_PRELIGHT]); case COL_ROW_FULL_SELECTION: color = GO_COLOR_FROM_GDK (style->dark[GTK_STATE_NORMAL]); font_color = GO_COLOR_FROM_GDK (style->fg[GTK_STATE_NORMAL]); On the other hand I don't recall ever seeing a difference between a completely selected column and a partially selected column.
I have changed the row and column headers to use the SELECTED colours for COL_ROW_PARTIAL_SELECTION and .COL_ROW_FULL_SELECTION and the NORMAL colour for COL_ROW_NO_SELECTION. I tried it out with various themes and it does look better. I am leaving it open since the selection colour of the cells still needs to be fixed.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.