After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638965 - Not have underlined letter with default profile combo box
Not have underlined letter with default profile combo box
Status: RESOLVED WONTFIX
Product: orca
Classification: Applications
Component: general
2.91.x
Other All
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
profiles
Depends on:
Blocks:
 
 
Reported: 2011-01-08 06:36 UTC by Hammer Attila
Modified: 2011-01-10 11:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A patch with fix for this bug (1.54 KB, patch)
2011-01-08 06:55 UTC, Hammer Attila
reviewed Details | Review

Description Hammer Attila 2011-01-08 06:36:34 UTC
Dear Developers,

In Orca preferences dialog, the active profile combo box have an underlined mnemonics letter, but the startup profile combo box not have this quick key combination.
The orca-setup.ui file not containing the                                             <property name="use_underline">True</property> tag.

I will be make a patch. If my patch is good and you would like add a mnemonics key with the default profile combo box, please commit my patch.

Attila
Comment 1 Hammer Attila 2011-01-08 06:55:42 UTC
Created attachment 177804 [details] [review]
A patch with fix for this bug

This patch fixing this bug. Now I assigned the startup profile combo box label the p mnemonic letter.
If want, feel free modify the underlined letter.

Attila
Comment 2 Joanmarie Diggs (IRC: joanie) 2011-01-09 18:31:58 UTC
Review of attachment 177804 [details] [review]:

Thanks Attila.

However, as I stated on the orca-list in December [1], when I added a shortcut for Active Profile:

~~~~~~~~~~~~
So now I can hear you responding, "great, but the startup profile combo
box still lacks a shortcut." This is indeed the case. But already we are
duplicating shortcuts, and for some locales it is worse than others. So
I have to question the value of giving every last widget a shortcut.
It's only a few presses of Tab to get from Active Profile (now with
shortcut) to Startup Profile. And you presumably won't be changing your
startup profile all that often. So my vote would be to leave the Startup
Profile combo box without a dedicated shortcut. Having said that, I'll
allow you or others to convince me otherwise if there is a compelling
enough use case. <smile>
~~~~~~~~~~~~

We've not got that compelling enough use case. I really don't see adding this, I'm afraid.

[1] http://mail.gnome.org/archives/orca-list/2010-December/msg00157.html
Comment 3 Hammer Attila 2011-01-10 05:24:51 UTC
Joanie, sorry, I forgot this answer.
Full agree the answer because in english locale have lot of equals shortcut keys for controls and this is difficulting the dialog handle with english language users.

So, if not have another users with shortcut for default profile combo box, feel free to set this bug status with resolved or wont fix status.

Attila
Comment 4 Joanmarie Diggs (IRC: joanie) 2011-01-10 11:19:54 UTC
It's not just in English. Spanish, at least, has the same problem. I suspect if I were to check in other languages -- at least Romance languages -- I'd find the same thing.

What we need to do is focus on having shortcuts in important places, rather than for every place. And we do have a shortcut for the first, and mostly likely needed, widget in the Profiles group.