After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637656 - GPointingDeviceSettings crashes if Watch DevicePresenceNotify event patch is applied
GPointingDeviceSettings crashes if Watch DevicePresenceNotify event patch is ...
Status: RESOLVED WONTFIX
Product: GPointingDeviceSettings
Classification: Other
Component: Core
git master
Other Linux
: Normal major
: ---
Assigned To: GPointingDeviceSettings-maint
GPointingDeviceSettings-maint
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2010-12-20 11:36 UTC by Peter
Modified: 2018-08-17 18:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gpointing-device-settings-1.5.1-gsd-crash.patch (2.01 KB, patch)
2011-02-12 12:19 UTC, Pacho Ramos
none Details | Review

Description Peter 2010-12-20 11:36:17 UTC
Hi. In Gentoo we apply fix for bug 609050 and this caused bug report about crash:
https://bugs.gentoo.org/show_bug.cgi?id=345343

Backtrace is the following:
Program received signal SIGSEGV, Segmentation fault.
0x00007fffebf65a1a in device_presence_filter (xevent=0x7fffffffd9c0,
event=0x830720, data=0x669ba0) at gsd-pointing-device-plugin.c:102
102     gsd-pointing-device-plugin.c: No such file or directory.
        in gsd-pointing-device-plugin.c
  • #0 device_presence_filter
    at gsd-pointing-device-plugin.c line 102
  • #1 gdk_event_apply_filters
    at gdkevents-x11.c line 351
  • #2 gdk_event_translate
    at gdkevents-x11.c line 922
  • #3 _gdk_events_queue
    at gdkevents-x11.c line 2305
  • #4 gdk_event_dispatch
    at gdkevents-x11.c line 2366
  • #5 g_main_dispatch
    at gmain.c line 1960
  • #6 IA__g_main_context_dispatch
    at gmain.c line 2513
  • #7 g_main_context_iterate
    at gmain.c line 2591
  • #8 IA__g_main_loop_run
    at gmain.c line 2799
  • #9 IA__gtk_main
    at gtkmain.c line 1219
  • #10 main
    at main.c line 502

And user suggested following fix:
https://bugs.gentoo.org/show_bug.cgi?id=345343#c13

Please, review, and apply if it is correct.
Comment 1 Pacho Ramos 2011-02-11 16:17:08 UTC
Can you take a look on this please? Thanks
Comment 2 Pacho Ramos 2011-02-12 12:19:39 UTC
Created attachment 180719 [details] [review]
gpointing-device-settings-1.5.1-gsd-crash.patch

This is the patch by Alexandre Rostovtsev that looks to fix this problem. On the other hand, Tiziano Muller commented in downstream bug report the following:
https://bugs.gentoo.org/show_bug.cgi?id=345343#c15

"Even though the patch works, I'm not sure whether it is the right thing to do.
Why don't we get a device_info even though the fact that the
device_presence_filter is called indicates that we should have one?
Does somebody know whether we have no devices at all (in which case the
device_presence_filter should not have been called in the first place) or we
just don't get an XExtensionPointer? (which makes me wonder why we don't hit
that bug on login)"

Then, if you could help us with this, it would be great. Thanks
Comment 3 André Klapper 2018-08-17 18:38:50 UTC
GPointingDeviceSettings is not under active development anymore and saw its last non-cosmetic code changes in 2010. Its codebase has been archived:
https://gitlab.gnome.org/Archive/gpointing-device-settings/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect
reality. Please feel free to reopen this ticket (or rather transfer the project
to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the
responsibility for active development again.