Created attachment 176391 [details] [review]
Don't skip vfuncs that have a corresponding signal

Otherwise subclasses don't have a mean to override the parent's
behavior.

Created attachment 176393 [details] [review]
Remove warning about a vfunc not having an invoker

As library authors don't want to add those invokers to their
public APIs. Bindings need to be able to register function wrappers
from the vfunc info.

Shouldn't this be filed against g-i? (the patches are for the scanner...)


Also it is probably the same problem reported in bug #635460 which tries to fix it on the pygobject side

(In reply to comment #3)
> Shouldn't this be filed against g-i? (the patches are for the scanner...)
> 
> 
> Also it is probably the same problem reported in bug #635460 which tries to fix
> it on the pygobject side

Oops, thanks for telling, I filed in the wrong component.

Review of attachment 176391 [details] [review]:

There's really no test updates for this one?  Did you run "make check"?

If there's no tests we should add one.

Review of attachment 176393 [details] [review]:

Oh I see, this one has the test updates for the previous one.

Can you squash to preserve bisectability?

I'm sad to see this check go; one tricky thing is that for some vfuncs the invoker has important default behavior (e.g. in gio).  But I guess we can't warn for all of them.

[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]