GNOME Bugzilla – Bug 637206
minor styling nitpicks on the dash
Last modified: 2011-02-02 21:45:17 UTC
Created attachment 176387 [details] [review] minor CSS tweaks to the dash Attached is a patch to address a few changes on the dash styling based on the latest design*. The stroke is to be 1px and the icon labels a tad smaller. * http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/dash-dnd-reorder.png
Created attachment 176395 [details] [review] dash styling Falsely styled the global .app-well-app last night. Now only the dash labels are small. In addition all dash selectors are brought together. I also indented the dash context selectors which is something that I think would make the stylesheet look more legible if applied across the whole file.
Too late noticed the padding changes seem to interfere with the size thresholding, making the icons fuzzy.
Review of attachment 176395 [details] [review]: Mostly good, but note that the non-uniform padding was intentional - see comment below. ::: data/theme/gnome-shell.css @@ +315,3 @@ #dash { color: #5f5f5f; + padding: 4px; This change breaks Fitts' law for the dash. @@ +333,3 @@ + + #dash .overview-icon { + font-size: 9px; I'd remove the overwritten .app-well-app > .overview-icon { font-size: 10px; } for clarity. @@ +502,3 @@ .remove-favorite-icon { color: #a0a0a0; } This should probably go in the dash section as well.
I took the freedom of including the visual changes in this patch in the patch series in bug 636156 - it would be great if you can have a quick look there to make sure I didn't skip anything you consider important. *** This bug has been marked as a duplicate of bug 636156 ***