After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637145 - Add g_vfunc_info_invoke
Add g_vfunc_info_invoke
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 637165
 
 
Reported: 2010-12-13 12:56 UTC by Tomeu Vizoso
Modified: 2015-02-07 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add g_vfunc_info_invoke (15.73 KB, patch)
2010-12-13 12:56 UTC, Tomeu Vizoso 		reviewed Details | Review
Add g_vfunc_info_invoke and g_vfunc_info_get_address (16.04 KB, patch)
2010-12-13 16:49 UTC, Tomeu Vizoso 		none Details | Review
Add g_vfunc_info_invoke and g_vfunc_info_get_address (16.40 KB, patch)
2010-12-28 18:09 UTC, Tomeu Vizoso 		none Details | Review
Add g_vfunc_info_invoke and g_vfunc_info_get_address (17.78 KB, patch)
2011-01-12 18:56 UTC, Tomeu Vizoso 		committed Details | Review

Description Tomeu Vizoso 2010-12-13 12:56:35 UTC 
this is needed so we can chain up to an ancestor's implementation of a vfunc.
Comment 1 Tomeu Vizoso 2010-12-13 12:56:37 UTC 
Created attachment 176331 [details] [review]
Add g_vfunc_info_invoke

for calling the native implementation of a virtual function. Refactors
the code common with g_function_info_invoke in _g_callable_info_invoke.
Comment 2 Colin Walters 2010-12-13 16:13:44 UTC 
Hmm, I think I'd prefer a base API which can get the function pointer, i.e. _find_vfunc_pointer should be public.

I don't mind the refactoring to _g_callable_info_invoke.

But the goal for bindings should be direct invocation again; going through _g_callable_info_invoke is just pure overhead.
Comment 3 Colin Walters 2010-12-13 16:14:00 UTC 
Review of attachment 176331 [details] [review]:

See comment above.
Comment 4 Tomeu Vizoso 2010-12-13 16:49:31 UTC 
Created attachment 176346 [details] [review]
Add g_vfunc_info_invoke and g_vfunc_info_get_address

for calling the native implementation of a virtual function. Refactors
the code common with g_function_info_invoke in _g_callable_info_invoke.
Comment 5 Tomeu Vizoso 2010-12-28 18:09:22 UTC 
Created attachment 177152 [details] [review]
Add g_vfunc_info_invoke and g_vfunc_info_get_address

for calling the native implementation of a virtual function. Refactors
the code common with g_function_info_invoke in _g_callable_info_invoke.
Comment 6 Tomeu Vizoso 2011-01-12 18:56:48 UTC 
Created attachment 178168 [details] [review]
Add g_vfunc_info_invoke and g_vfunc_info_get_address

for calling the native implementation of a virtual function. Refactors
the code common with g_function_info_invoke in _g_callable_info_invoke.
Comment 7 Tomeu Vizoso 2011-01-12 19:06:54 UTC 
ACK'ed by jdahlin on #introspection

Attachment 178168 [details] pushed as 0c3a1d8 - Add g_vfunc_info_invoke and g_vfunc_info_get_address
Comment 8 André Klapper 2015-02-07 16:50:08 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]