GNOME Bugzilla – Bug 637115
Orca needs to have Miramar added to the list of names for thunderbird scripts
Last modified: 2010-12-18 01:33:09 UTC
Version 3.3 of thunderbird is called Miramar and so the mapping for the thunderbird script needs updating for this. I should have a patch ready in a few minutes.
Created attachment 176319 [details] [review] A proposed patch This patch solves the bug for me.
Adding myself to the CC list and thanks for the patch. I haven't installed a late beta of thunderbird yet but am willing to try it out. I also want to be sure the html viewing of messages isn't as broken as it is in Firefox. I mean broken in the sense of consistent behavior with tabbing between links and controls.
Comment on attachment 176319 [details] [review] A proposed patch http://git.gnome.org/browse/orca/commit/?id=ceb44f2fb3c15f13ab9aba0da9c0473fc8fa1773
Super Michael. Thanks! BTW it's extremely cool to just be apply to git am and git push your patches. I appreciate your taking the extra time to prepare commit-ready items. p.s. Maybe we can file a bug against Thunderbird to stop with the always-different accessible application name changes, for pete's sake? <tired smile>
(In reply to comment #4) > Super Michael. Thanks! BTW it's extremely cool to just be apply to git am and > git push your patches. I appreciate your taking the extra time to prepare > commit-ready items. > > p.s. Maybe we can file a bug against Thunderbird to stop with the > always-different accessible application name changes, for pete's sake? <tired > smile> I agree that mozilla could keep this down or at least guarantee us that it will always begin thunderbird/firefox (eg. Miramar could have been "Thunderbird Miramar", obviously if spaces aren't allowed put a - in there). How would you feel about that if they want the codename in the application name? Also fixing this bug made me wonder, why isn't there a way of extending the apllication name and script matching mapping dictionary by passing a dictionary into a function/method call? As an example,: extendScriptMapping({re.compile('Lanikai'): 'Thunderbird', re.compile('Miramar'): 'Thunderbird'}) or may be a script and list of aliases: addScriptMappings([re.compile('Lanikai'), re.compile('Miramar')], 'Thunderbird') Calling either of these would add the mappings to the existing ones for the given script.