Created attachment 175492 [details] [review]
workspace: Consider text direction when switching

A direction parameter is passed to meta_compositor_switch_workspace(),
to indicate the direction of the switch depending on the workspace
layout.
In contrast to the switcher popup, this parameter does not take the
text direction of the locale into account. Change this, so that the
workspace order appears correctly when running under RTL locales.

Review of attachment 175492 [details] [review]:

Looks fine, though I'd sneak in an else into:

+       if (layout1.current_col > layout2.current_col)
+         direction = META_MOTION_RIGHT;
+       if (layout1.current_col < layout2.current_col)
+         direction = META_MOTION_LEFT;

as long as you are changing that code.

And:

Change this, so that the
workspace order appears correctly when running under RTL locales.

isn't right? it's should be "workspace switching animations move in the correct direction?"

Attachment 175492 [details] pushed as 6b98644 - workspace: Consider text direction when switching

(In reply to comment #2)
> Looks fine, though I'd sneak in an else into:

Done.


> it should be "workspace switching animations move in the correct
> direction?"

Hmm, yeah ... fixed as well.