After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635364 - Add C include and exported packages information to GIR
Add C include and exported packages information to GIR
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks: 635330
 
 
Reported: 2010-11-20 17:38 UTC by Evan Nemerson
Modified: 2011-01-19 11:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
introspection: Add C include and exported packages information to GIR (1013 bytes, patch)
2010-11-20 17:40 UTC, Evan Nemerson 		committed Details | Review

Description Evan Nemerson 2010-11-20 17:38:04 UTC 
GdkPixbuf-2.0.gir does not currently include information on the C header to include or the exported packages, both of which are important for generating Vala bindings from the GIR.
Comment 1 Evan Nemerson 2010-11-20 17:40:29 UTC 
Created attachment 174918 [details] [review]
introspection: Add C include and exported packages information to GIR
Comment 2 Bastien Nocera 2011-01-13 16:24:29 UTC 
Looks good to me.
Comment 3 Colin Walters 2011-01-13 16:41:17 UTC 
Review of attachment 174918 [details] [review]:

::: gdk-pixbuf/Makefile.am
@@ +679,2 @@
 GdkPixbuf-2.0.gir: libgdk_pixbuf-2.0.la Makefile
+GdkPixbuf_2_0_gir_SCANNERFLAGS = --warn-all --strip-prefix=Gdk --c-include="gdk-pixbuf/gdk-pixdata.h"

Shouldn't that be --c-include="gdk-pixbuf/gdk-pixbuf.h"

The c:include is intended to specify which C header library consumers need to access what's in the .gir, and that's definitely not gdk-pixdata.h in this case.
Comment 4 Bastien Nocera 2011-01-13 16:56:16 UTC 
Fixed with the change mentioned by Colin.

Attachment 174918 [details] pushed as 9671e0f - introspection: Add C include and exported packages information to GIR
Comment 5 Evan Nemerson 2011-01-13 21:38:12 UTC 
The problem with just using gdk-pixbuf/gdk-pixbuf.h is that gdk-pixbuf/gdk-pixdata.h doesn't get included, and the GdkPixdata stuff is part of the GdkPixbuf GIR. The current Vala bindings work around this by using gdk-pixbuf/gdk-pixdata.h instead, which will include gdk-pixbuf/gdk-pixbuf.h. Perhaps --c-include="gdk-pixbuf/gdk-pixbuf.h,gdk-pixbuf/gdk-pixdata.h"? Or is the fact that gdk-pixbuf/gdk-pixbuf.h doesn't include gdk-pixbuf/gdk-pixdata.h unintentional?