GNOME Bugzilla – Bug 635288
Update for gnome-power-manager API changes
Last modified: 2010-11-22 17:06:55 UTC
Following bug 633703, g-p-m DBus API has changed, and the shell is now broken. We need to fix it.
Created attachment 174867 [details] [review] PowerStatus: Update for gnome-power-manager API changes g-p-m no longer exports a summary, and instead exports a GIcon to show. Update for that.
Comment on attachment 174867 [details] [review] PowerStatus: Update for gnome-power-manager API changes >+ this._label = new St.Label({ text: GPMGettext.gettext(this._deviceTypeToString(device_type)) }); Hm. No, don't use g-p-m's translations for strings that are coming from our source code; if g-p-m tweaks things again later (eg, maybe changing capitalization of something), then we'd suddenly lose translations. So just use _() and we'll make our own translations. >+ return 'AC Adapter'; 'AC adapter', for consistency with the other strings >+ return 'Chell phone'; typo
Created attachment 174889 [details] [review] PowerStatus: Update for gnome-power-manager API changes g-p-m no longer exports a summary, and instead exports a GIcon to show. Update for that.
Not fixed yet, see below...
Created attachment 174915 [details] [review] Complete porting to new gnome-power-manager API We updated the normal devices part, but we forgot the part about the primary device (possibly because it is not reported as such in case it is fully charged). Update that as well, to avoid showing weird GIcon serializations.