After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635142 - [PATCH] use asynchronous i/o for vtefilestream
[PATCH] use asynchronous i/o for vtefilestream
Status: RESOLVED OBSOLETE
Product: vte
Classification: Core
Component: general
0.27.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-18 03:29 UTC by Bill Nottingham
Modified: 2021-06-10 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use async i/o (818 bytes, patch)
2010-11-18 03:29 UTC, Bill Nottingham 		needs-work Details | Review

Description Bill Nottingham 2010-11-18 03:29:06 UTC 
Because really, why should writing to the unlinked scrollback file block all your terminals?
Comment 1 Bill Nottingham 2010-11-18 03:29:30 UTC 
Created attachment 174748 [details] [review]
use async i/o
Comment 2 Behdad Esfahbod 2010-11-18 05:11:35 UTC 
Thanks!  I'll review tomorrow.

Do note however that the patch only fixes the "Save contents" menu option.  The scrollback stuff is still synchronous.  Fixing that is more involved but definitely something worth looking into.  We should first add a buffering vtestream though so we don't do i/o for every single line going into the scrollback buffer.
Comment 3 Bill Nottingham 2010-11-18 13:52:36 UTC 
Hm, I'm pretty sure when I broke into gnome-terminal when it was hanging writing scrollback, this was where it was.
Comment 4 Behdad Esfahbod 2010-11-18 18:24:45 UTC 
That's impossible.

Plus, we can't do asynch writing without locking the data down first.  It's possible, but more complicated than your patch.  I *wish* it was that simple :)
Comment 5 Bill Nottingham 2010-11-18 18:48:13 UTC 
(In reply to comment #4)
> That's impossible.

Oops, you're right - it's going through file_stream_append, and xwrite.
Comment 6 Behdad Esfahbod 2010-11-18 18:49:52 UTC 
So what was the situation that made you start the debugger?  What's your /tmp mounted on?
Comment 7 GNOME Infrastructure Team 2021-06-10 14:28:29 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/vte/-/issues/1856.