After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 635093 - GLib 2.26.1: Fix sources for compilation on MSVC 2008/C89 compilers
GLib 2.26.1: Fix sources for compilation on MSVC 2008/C89 compilers
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.26.x
Other Windows
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 632574 632577 632581 (view as bug list)
Depends on:
Blocks: 631102
 
 
Reported: 2010-11-17 17:30 UTC by Fan, Chun-wei
Modified: 2011-01-30 07:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Updates to GLib 2.26.x sources (6.75 KB, patch)
2010-11-17 17:30 UTC, Fan, Chun-wei 		none Details | Review

Description Fan, Chun-wei 2010-11-17 17:30:36 UTC 
Created attachment 174703 [details] [review]
Updates to GLib 2.26.x sources

This bug report is alongside with bug #631102 to update the source files for compilation under MSVC 2008 and probably other C89 compilers.  Summary of the fixes:

glib/gtimer.c
glib/gdatetime.c
glib/gscanner.c
glib/gmessages.c -> Added or moved platform check macros to allow correct compilation on MSVC

tests/testglib.c -> added G_DISABLE_DEPRECATED check around the relation test (deprecated API)

gio/gdbusmessage.c
gio/gregistrysettingsbackend.c -> Fixed C99-style variable declaration.

Please let me know of any comments and whether I can commit those fixes.  Thanks
Comment 1 Fan, Chun-wei 2010-11-30 02:13:26 UTC 
Commited to the glib-2-26 branch after reviewing with Tor.  Thanks
Comment 2 Kazuki Iwamoto 2011-01-30 07:27:27 UTC 
*** Bug 632574 has been marked as a duplicate of this bug. ***
Comment 3 Kazuki Iwamoto 2011-01-30 07:29:57 UTC 
*** Bug 632577 has been marked as a duplicate of this bug. ***
Comment 4 Kazuki Iwamoto 2011-01-30 07:35:18 UTC 
*** Bug 632581 has been marked as a duplicate of this bug. ***