After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634752 - Skip drawing transparent borders and backgrounds
Skip drawing transparent borders and backgrounds
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-11-13 13:35 UTC by Owen Taylor
Modified: 2010-11-13 15:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Skip drawing transparent borders and backgrounds (14.10 KB, patch)
2010-11-13 13:35 UTC, Owen Taylor 		committed Details | Review
Same patch with -w for ease of review (3.35 KB, patch)
2010-11-13 13:37 UTC, Owen Taylor 		none Details | Review

Description Owen Taylor 2010-11-13 13:35:49 UTC 
We were always drawing the border and background of each
StThemeNode, even if they were transparent. The simple
optimization of checking the alpha provides a significant
performance boost (in a quick test, it increased the
overviewFpsSubsequent metric in the core performance test
from 28fps to 35fps).
Comment 1 Owen Taylor 2010-11-13 13:35:51 UTC 
Created attachment 174388 [details] [review]
Skip drawing transparent borders and backgrounds
Comment 2 Owen Taylor 2010-11-13 13:37:12 UTC 
Created attachment 174389 [details] [review]
Same patch with -w for ease of review
Comment 3 Florian Müllner 2010-11-13 14:49:20 UTC 
Review of attachment 174388 [details] [review]:

Looks good.
Comment 4 Owen Taylor 2010-11-13 15:24:44 UTC 
Attachment 174388 [details] pushed as 3138b20 - Skip drawing transparent borders and backgrounds