GNOME Bugzilla – Bug 634277
Update to gtk/gtktoolitemgroup.c due to use of to-be-deprecated GLib API
Last modified: 2010-11-15 06:14:02 UTC
Created attachment 174046 [details] [review] The updates to gtk/gtktoolitemgroup.c As of GLib 2.27.2, and the upcoming 2.28 and future releases will deprecate g_source_get_current_time, the patch attempts to address that issue by checking the GLib version used (the new code is not usable in GLib 2.26.0 so far). This is a rough estimate on the code involved by this change, so any comments are welcome. Thanks
+#if (GLIB_MAJOR_VERSION > 2 || (GLIB_MAJOR_VERSION == 2 && GLIB_MINOR_VERSION > 27) || (GLIB_MAJOR_VERSION == 2 && GLIB_MINOR_VERSION == 27 && GLIB_MICRO_VERSION > 1)) There's the GLIB_CHECK_VERSION macro for that. Why not just bump the glib req in configure ?
Created attachment 174063 [details] [review] Updated patch for gtk/gtktoolitemgroup.c Thanks Christian for the point... About the configure part, I would probably not be able to sort that out as I am too familiar with autotools, so perhaps on my side updating the code will be easier
Sorry, I typed wrongly: it should read I would probably not be able to sort that out as I am *not* too familiar with autotools Thanks > Thanks Christian for the point... > > About the configure part, I would probably not be able to sort that out as I am > too familiar with autotools, so perhaps on my side updating the code will be > easier
Review of attachment 174063 [details] [review]: As chpe said, simply bump the Glib required version in configure.ac, so we don't have to use conditional #ifdef code
The glib dep has been bumped already.
Reopening as this patch is for the gtk-2-24 branch, not master
Due to changes in GLib 2.27.x, I have posted another patch of changes in bug 634882. Sorry. *** This bug has been marked as a duplicate of bug 634882 ***