After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 634266 - Use inline documentation
Use inline documentation
Status: RESOLVED FIXED
Product: libnotify
Classification: Platform
Component: general
0.7.x
Other All
: Normal normal
: ---
Assigned To: William Jon McCann
Depends on:
Blocks:
 
 
Reported: 2010-11-08 03:51 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-11-14 16:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Move-documentation-to-inline-comments-notification (8.51 KB, patch)
2010-11-08 03:52 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Move-documentation-to-inline-comments-notify (2.27 KB, patch)
2010-11-08 03:52 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Do-not-generate-template-files (2.98 KB, patch)
2010-11-08 03:52 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Update-libnotify-sections (1.36 KB, patch)
2010-11-08 03:53 UTC, Javier Jardón (IRC: jjardon) 		none Details | Review
Some-fixes (1.83 KB, patch)
2010-11-08 03:53 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-11-08 03:51:44 UTC 
Here some patches to move all the documentation to inline comments and to fix some issues.
Comment 1 Javier Jardón (IRC: jjardon) 2010-11-08 03:52:11 UTC 
Created attachment 174039 [details] [review]
Move-documentation-to-inline-comments-notification
Comment 2 Javier Jardón (IRC: jjardon) 2010-11-08 03:52:27 UTC 
Created attachment 174040 [details] [review]
Move-documentation-to-inline-comments-notify
Comment 3 Javier Jardón (IRC: jjardon) 2010-11-08 03:52:44 UTC 
Created attachment 174041 [details] [review]
Do-not-generate-template-files
Comment 4 Javier Jardón (IRC: jjardon) 2010-11-08 03:53:01 UTC 
Created attachment 174042 [details] [review]
Update-libnotify-sections
Comment 5 Javier Jardón (IRC: jjardon) 2010-11-08 03:53:16 UTC 
Created attachment 174043 [details] [review]
Some-fixes
Comment 6 William Jon McCann 2010-11-14 16:11:18 UTC 
Review of attachment 174043 [details] [review]:

Pushed with this one change.

::: libnotify/notification.c
@@ +722,3 @@
  *
  * Sets a hint for @key with value @variant. If @value is %NULL,
  * a previously set hint for @key is unset.

Looks like the text below that also needs to be changed since it uses both @value and @variant.
Comment 7 William Jon McCann 2010-11-14 16:11:47 UTC 
Seems to work.  Pushed to master.  Thanks!