After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633886 - Visual Studio emits warnings about double defined _USE_MATH_DEFINES
Visual Studio emits warnings about double defined _USE_MATH_DEFINES
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-03 09:18 UTC by Vladimir Eremeev
Modified: 2010-11-03 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Kill MSVC warnings about double defined _USE_MATH_DEFINES (402 bytes, patch)
2010-11-03 09:18 UTC, Vladimir Eremeev 		committed Details | Review

Description Vladimir Eremeev 2010-11-03 09:18:01 UTC 
Created attachment 173756 [details] [review]
Kill MSVC warnings about double defined _USE_MATH_DEFINES

The attached patch kills these warnings.
Comment 1 Tim-Philipp Müller 2010-11-03 14:30:18 UTC 
Thanks a lot for the patch. I've pushed this:

 commit b804d533204183b2ef72bf0105e1df9ea359893e
 Author: Vladimir Eremeev <wl2776@gmail.com>
 Date:   Wed Nov 3 14:21:02 2010 +0000

    math-compat: don't re-define _USE_MATH_DEFINES if already defined
    
    This avoids compiler warnings.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=633886


It would be helpful if you could change your bugzilla preferences so that your full name is shown - that makes it easier to credit you for your work. And/or provide patches in git format-patch format, which would include your name and a commit message already then, see SubmittingPatches page on the wiki :)