After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633819 - update libnotify bindings for 0.7.0
update libnotify bindings for 0.7.0
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2010-11-02 14:16 UTC by Matthias Clasen
Modified: 2010-11-08 10:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Matthias Clasen 2010-11-02 14:16:35 UTC 
libnotify 0.7.0 changes api:

notify_notification_new_with_status_icon   is gone
notify_notification_attach_to_status_icon  is gone
notify_notification_attach_to_widget       is gone
notify_notification_set_geometry_hints     is gone
notify_notification_new                    has lost its widget argument
Comment 1 Evan Nemerson 2010-11-02 19:30:42 UTC 
Did libnotify change its pkg-config name?
Comment 2 Matthias Clasen 2010-11-02 20:26:02 UTC 
No, and it is not parallel-installable or anything like that.
Comment 3 Evan Nemerson 2010-11-02 21:01:58 UTC 
Jürg, what do you think about defining PACKAGE_MAJOR_MINOR for 0..MINOR based on the pkg-config version, kind of like what valac already does for glib (although I don't think it starts from 0)? Then we could do something like

#if LIBNOTIFY_0_7
public Notification ();
#else
public Notification (Gtk.Widget widget);
#endif

I haven't looked at the API, but that should be enough to convey the idea...
Comment 4 Jürg Billeter 2010-11-08 08:03:03 UTC 
I don't think we should define this based on pkg-config version retrieved at compile-time as this might lead to confusing or surprising results on different systems. For GLib we don't use the version from pkg-config, we use the version specified on the valac command line to not accidentally depend on newer GLib versions.

In my opinion, we should default to libnotify 0.7 API in vala master as Vala is roughly following the GNOME release schedule. The old API can be supported using a define (e.g., LIBNOTIFY_0_5) that needs to be given on the valac command line.
Comment 5 Evan Nemerson 2010-11-08 10:54:14 UTC 
commit 4d35d0d5253f482ea845508e6cfb262596a7305e
Author: Evan Nemerson <evan@coeus-group.com>
Date:   Mon Nov 8 02:43:46 2010 -0800

    libnotify: Update to 0.7.0
    
    Fixes bug 633819.