After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633324 - Stop invoking size-request completely
Stop invoking size-request completely
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: 3.0
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 629471
 
 
Reported: 2010-10-28 06:20 UTC by Tristan Van Berkom
Modified: 2010-11-19 18:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for gtksizerequest.c to stop emitting size-request (2.23 KB, patch)
2010-10-28 06:20 UTC, Tristan Van Berkom 		none Details | Review

Description Tristan Van Berkom 2010-10-28 06:20:36 UTC 
Created attachment 173380 [details] [review]
Patch for gtksizerequest.c to stop emitting size-request

This patch finishes up the "kill-size-request" branch by
updating gtksizerequest.c to stop invoking the signal.

However as I understand we want a lapse where there is a
deprecation, this patch should be applied along with the removal
of the actual vfunc/signal from GtkWidgetClass.
Comment 1 Michael Natterer 2010-11-19 18:40:15 UTC 
Fixed in master, plus killing the signal:

commit bc0e6b2b2189c973cd415724d842020763b9dee6
Author: Michael Natterer <mitch@gimp.org>
Date:   Fri Nov 19 19:38:48 2010 +0100

    gtk: remove GtkWidget::size-request
    
    Fixes Bug 633324 - Stop invoking size-request completely

 gtk/gtksizerequest.c |   41 +++--------------------------------------
 gtk/gtkwidget.c      |   34 ----------------------------------
 gtk/gtkwidget.h      |    2 --
 3 files changed, 3 insertions(+), 74 deletions(-)