GNOME Bugzilla – Bug 633280
[icydemux][PATCH] icydemux: Send 'StreamUrl' metadata as GST_TAG_HOMEPAGE tag
Last modified: 2010-12-02 18:26:56 UTC
Created attachment 173342 [details] [review] 0001-icydemux-Add-StreamUrl-metadata-as-GST_TAG_HOMEPAGE-.patch Comment out the part that parses the StreamUrl metadata and parse it as GST_TAG_HOMEPAGE tag.
(In reply to comment #0) > Created an attachment (id=173342) [details] [review] > 0001-icydemux-Add-StreamUrl-metadata-as-GST_TAG_HOMEPAGE-.patch > > Comment out the part that parses the StreamUrl metadata and parse it as > GST_TAG_HOMEPAGE tag. This should be read: Uncomment ...
I don't think the HOMEPAGE tag is the correct one for this. The HOMEPAGE would be the website for the stream for example, not the URL to the stream itself. We might need to add some kind of URL tag... or you could use the URI query to get the URI.
In most of the icecast server I have used, this tag specifies the url of the website producing the stream. Here is an example: http://www.kukita.com.ar:8000/
It's also specified in the documentation (http://www.icecast.org/docs/icecast-2.3.2/icecast2_config_file.html#mount): "<stream-url>http://some.place.com</stream-url>"
From the same docs: "stream-url: Setting this will add the specified URL to the stats (and therefore YP) for this mountpoint even if the source client/relay provide one. The URL is generally for directing people to a website."
Comment on attachment 173342 [details] [review] 0001-icydemux-Add-StreamUrl-metadata-as-GST_TAG_HOMEPAGE-.patch Oh ok, I'll push this after release then. Thanks :)
Cool, thanks :)
commit be2d04e040aa3a6fb556f660fbfa624d32a3f017 Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Wed Oct 27 19:15:20 2010 +0200 icydemux: Add 'StreamUrl' metadata as GST_TAG_HOMEPAGE tag