After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 633133 - Remove compatibility for GTK+-2.0
Remove compatibility for GTK+-2.0
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-25 19:31 UTC by Florian Müllner
Modified: 2010-10-28 10:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove compatibility for GTK+-2.0 (62.33 KB, patch)
2010-10-25 19:31 UTC, Florian Müllner
reviewed Details | Review
Remove compatibility for GTK+-2.0 (104.03 KB, patch)
2010-10-25 20:30 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2010-10-25 19:31:09 UTC
See patch.
Comment 1 Florian Müllner 2010-10-25 19:31:12 UTC
Created attachment 173212 [details] [review]
Remove compatibility for GTK+-2.0

While the Meego developers agreed to switching mutter to GTK+-3.0
unconditionally a while ago, Canonical used a GTK+-2.0 build for their
Unity project. As Canonical now announced a switch to compiz as their
window manager, there is no longer a reason to maintain GTK+-2.0
compatibility.
Comment 2 Owen Taylor 2010-10-25 19:42:12 UTC
Review of attachment 173212 [details] [review]:

There should be a configure.ac part of this?

::: src/include/errors.h
@@ +32,3 @@
 void      meta_error_trap_push (MetaDisplay *display);
 void      meta_error_trap_pop  (MetaDisplay *display,
                                 gboolean     last_request_was_roundtrip);

This boolean can go, right?
Comment 3 Florian Müllner 2010-10-25 20:30:49 UTC
Created attachment 173218 [details] [review]
Remove compatibility for GTK+-2.0

(In reply to comment #2)
> There should be a configure.ac part of this?

Woops - yes.


> ::: src/include/errors.h
> @@ +32,3 @@
>  void      meta_error_trap_pop  (MetaDisplay *display,
>                                  gboolean     last_request_was_roundtrip);
> 
> This boolean can go, right?

Right.
Comment 4 Owen Taylor 2010-10-25 20:44:31 UTC
Review of attachment 173218 [details] [review]:

Looks good. Should adjust the gnome-shell moduleset when we land this to remove the --with-gtk=3.0 parameter
Comment 5 Florian Müllner 2010-10-28 10:16:33 UTC
Attachment 173218 [details] pushed as b445ee3 - Remove compatibility for GTK+-2.0