After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632863 - [git] Account for '.git' suffix removal in srcdir
[git] Account for '.git' suffix removal in srcdir
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2010-10-22 08:45 UTC by Dirk Wallenstein
Modified: 2010-11-17 11:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[git] Account for '.git' suffix removal in srcdir (1.05 KB, patch)
2010-10-22 08:45 UTC, Dirk Wallenstein 		none Details | Review
A moduleset to test (365 bytes, text/plain)
2010-10-22 08:50 UTC, Dirk Wallenstein 		  Details
[git] Account for '.git' suffix removal in srcdir (1.09 KB, patch)
2010-10-31 08:37 UTC, Dirk Wallenstein 		committed Details | Review

Description Dirk Wallenstein 2010-10-22 08:45:56 UTC 
If there is no checkoutdir specified, git-clone will remove a '.git'
suffix from the clone URL to determine the destination directory.
Account for that in the srcdir property.
Comment 1 Dirk Wallenstein 2010-10-22 08:45:58 UTC 
Created attachment 172980 [details] [review]
[git] Account for '.git' suffix removal in srcdir
Comment 2 Dirk Wallenstein 2010-10-22 08:50:22 UTC 
Created attachment 172981 [details]
A moduleset to test

A moduleset to test the difference. The info subcommand shows the wrong source directory without this patch
Comment 3 Dirk Wallenstein 2010-10-31 08:37:27 UTC 
Created attachment 173586 [details] [review]
[git] Account for '.git' suffix removal in srcdir

If there is no checkoutdir specified, git-clone will remove a '.git'
suffix from the clone URL to determine the destination directory.
Account for that in the srcdir property.
Comment 4 Dirk Wallenstein 2010-10-31 08:40:55 UTC 
The new version of the patch should apply. I removed the subdir attribute for testing purposes and that got accidentally included.
Comment 5 Craig Keogh 2010-11-17 11:29:39 UTC 
Comment on attachment 173586 [details] [review]
[git] Account for '.git' suffix removal in srcdir

http://git.gnome.org/browse/jhbuild/commit/?id=605b2086cf0dd812f759af471d2dde34dc2a2bac
Comment 6 Craig Keogh 2010-11-17 11:30:49 UTC 
Thank you Dirk.