After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632795 - Separate "basic" API from "embedder/module" API
Separate "basic" API from "embedder/module" API
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-21 13:55 UTC by Colin Walters
Modified: 2010-10-21 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Separate "basic" API from "embedder/module" API (21.88 KB, patch)
2010-10-21 13:56 UTC, Colin Walters
accepted-commit_now Details | Review

Description Colin Walters 2010-10-21 13:55:57 UTC
Previously <gjs/gjs.h> pulled in a lot of stuff, and in particular,
<gjs/jsapi-util.h>, which in turn required <jsapi.h>.  For a simple
app that wants to embed GJS we should not be pulling that in.

So <gjs/gjs.h> is now the "simple" API that actually just includes
<gjs/context.h>, suitable for creating a context and calling eval().

<gjs/gjs-module.h> is now equivalent to the old <gjs/gjs.h>, it
pulls in the world.

Also, create a corresponding .pc file, gjs-internals-1.0.pc.  This one
includes mozjs as Requires, and adds the requisite Cflags.  For
gjs-1.0.pc, change the Requires to simply be gobject-2.0.
Conceptually, a gjs-devel RPM should not Require
gobject-introspection-devel or xulrunner-devel, and a simple embedder
program just using gjs_context_new()/gjs_context_eval() should not
have DT_NEEDED on gobject-introspection-1.0.so or mozjs.so.
Comment 1 Colin Walters 2010-10-21 13:56:00 UTC
Created attachment 172937 [details] [review]
Separate "basic" API from "embedder/module" API
Comment 2 Havoc Pennington 2010-10-21 14:11:46 UTC
Review of attachment 172937 [details] [review]:

seems logical to me
Comment 3 Colin Walters 2010-10-21 14:52:13 UTC
Thanks for the quick review!