After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632779 - gstdataqueue: Only emit g_cond_signal when needed
gstdataqueue: Only emit g_cond_signal when needed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-21 10:03 UTC by Edward Hervey
Modified: 2010-12-03 14:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstdataqueue: Only emit g_cond_signal when needed (3.98 KB, patch)
2010-10-21 10:03 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2010-10-21 10:03:41 UTC 
Keep track of which cond we're waiting for and only emit when needed.
Comment 1 Edward Hervey 2010-10-21 10:03:43 UTC 
Created attachment 172915 [details] [review]
gstdataqueue: Only emit g_cond_signal when needed
Comment 2 Sebastian Dröge (slomo) 2010-10-23 19:31:35 UTC 
Review of attachment 172915 [details] [review]:

Looks good to me in general but you realize that GST_PADDING usally is 4 and there's no padding left after your change? Also you add two gbooleans (i.e. int) but remove 2 pointers from the padding, I don't think you can assume that the struct padding will be the same on all architectures and the 2 booleans both take the space of a pointer.

Maybe we could add a private struct or use a single integer for the two booleans?
Comment 3 Edward Hervey 2010-12-03 14:17:47 UTC 
commit 7cc08390b91d88581a9b2a38b9d32aa522b268ca
Author: Edward Hervey <bilboed@bilboed.com>
Date:   Wed Oct 13 13:50:22 2010 +0200

    gstdataqueue: Only emit g_cond_signal when needed
    
    Keep track of which cond we're waiting for and only emit when needed.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=632779