After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632538 - Move setting property registration in gtksettings.c
Move setting property registration in gtksettings.c
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 585166 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-10-19 11:06 UTC by Emmanuele Bassi (:ebassi)
Modified: 2010-10-20 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
settings: Move setting property registration in gtksettings.c (16.02 KB, patch)
2010-10-19 11:06 UTC, Emmanuele Bassi (:ebassi) 		none Details | Review
settings: Move setting property registration in gtksettings.c (23.44 KB, patch)
2010-10-19 18:07 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2010-10-19 11:06:50 UTC 
Registering settings properties in different classes means that there is an undocumented prerequisite to instantiate that class in order to set a GtkSettings property - or get a warning from GObject that the property does not exist.

The attached patch moves back all GtkSettings properties scattered throughout gtk+ -- except for the one in GtkColorSel, because the default value is used internally as a fallback, and I'd like some feedback on how to handle it properly.
Comment 1 Emmanuele Bassi (:ebassi) 2010-10-19 11:06:53 UTC 
Created attachment 172690 [details] [review]
settings: Move setting property registration in gtksettings.c

Some GtkSettings property are registered by other classes. This leads
to the "interesting" issue that setting GtkSettings:gtk-button-images
requires that the GtkButton class is referenced first - or that a
GtkButton is created.
Comment 2 Christian Persch 2010-10-19 17:51:32 UTC 
There are a few more settings in gtkimcontextxim.c: "gtk-im-preedit-style", "gtk-im-status-style" (see bug 585166).
Comment 3 Emmanuele Bassi (:ebassi) 2010-10-19 18:07:42 UTC 
Created attachment 172748 [details] [review]
settings: Move setting property registration in gtksettings.c

Some GtkSettings property are registered by other classes. This leads
to the "interesting" issue that setting GtkSettings:gtk-button-images
requires that the GtkButton class is referenced first - or that a
GtkButton is created.
Comment 4 Emmanuele Bassi (:ebassi) 2010-10-19 18:10:55 UTC 
*** Bug 585166 has been marked as a duplicate of this bug. ***
Comment 5 Emmanuele Bassi (:ebassi) 2010-10-20 09:35:51 UTC 
Attachment 172748 [details] pushed as 9f9edb6 - settings: Move setting property registration in gtksettings.c