After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632535 - New note synced with no content
New note synced with no content
Status: RESOLVED FIXED
Product: tomboy
Classification: Applications
Component: General
1.3.x
Other Linux
: Immediate blocker
: 1.6.0
Assigned To: Tomboy Maintainers
Tomboy Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-19 10:32 UTC by Ross Burton
Modified: 2010-10-20 12:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Note that appears fine in Snowy (930 bytes, text/xml)
2010-10-19 10:32 UTC, Ross Burton
Details
Note that is only a title in Snowy (838 bytes, text/xml)
2010-10-19 10:32 UTC, Ross Burton
Details
Note that synced correctly, without xmllint --format (897 bytes, text/plain)
2010-10-19 11:46 UTC, Ross Burton
Details
Note that syncs with no content (805 bytes, text/plain)
2010-10-19 11:47 UTC, Ross Burton
Details

Description Ross Burton 2010-10-19 10:32:24 UTC
Created attachment 172685 [details]
Note that appears fine in Snowy

I just tried syncing to my new snowy account and most notes have no content, only a title.  I'll admit to recently switching back to Tomboy after a while using gnote, so it's possible that there is note corruption happening because of that but I can't see any relevant differences in the XML structure.

I've attached two notes, one of which is on Snowy fine and the other is only a title.
Comment 1 Ross Burton 2010-10-19 10:32:56 UTC
Created attachment 172686 [details]
Note that is only a title in Snowy
Comment 2 Ross Burton 2010-10-19 11:46:00 UTC
Created attachment 172701 [details]
Note that synced correctly, without xmllint --format
Comment 3 Ross Burton 2010-10-19 11:47:07 UTC
Created attachment 172702 [details]
Note that syncs with no content
Comment 4 Ross Burton 2010-10-19 11:47:27 UTC
Also, Tomboy 1.2.1.
Comment 5 Sandy Armstrong 2010-10-19 11:58:19 UTC
This is a Tomboy bug.  We make bad assumptions about the attributes in the note-content element, and even worse we use a regex to parse it, so these notes from gnote that have a few extra attributes in the note-content element are throwing off the sync code that parses the content (sans title) out of the note-content element.

Totally our bad, thanks so much for catching it, will fix ASAP and get into a 1.4.x bugfix release and git for 1.5.x.
Comment 6 Sandy Armstrong 2010-10-19 22:28:39 UTC
Fix pushed to gnome-2-30, gnome-2-32, and master.

Ross, if you could test this patch out, that would be great.  The unit test makes me pretty confident it's fixed, though.

http://git.gnome.org/browse/tomboy/patch/?id=08dfc2f2d813c9adcde67e4eb85093d0a6a0aee0

The best way to test this is for me to wipe out your data in Tomboy Online first.  Ping me when you're ready and I'll go ahead and do that.
Comment 7 Ross Burton 2010-10-20 12:11:05 UTC
If I touch an "empty" note and resync I now see content on snowy, thanks.