After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632313 - Add Timestamp to SyncSource DBUS Signal.
Add Timestamp to SyncSource DBUS Signal.
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-16 20:23 UTC by José Aliste
Modified: 2010-11-15 16:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[shell] Add timestamp to SyncSource DBUS signal. (1.48 KB, patch)
2010-10-16 20:23 UTC, José Aliste 		none Details | Review
[libview] Add timestamp to SyncSource signal. (2.97 KB, patch)
2010-10-16 20:23 UTC, José Aliste 		none Details | Review
[shell] add timestamp to SyncSource DBus signal. (1.69 KB, patch)
2010-10-17 15:11 UTC, José Aliste 		committed Details | Review

Description José Aliste 2010-10-16 20:23:09 UTC 
We need to add a timestamp to the SyncSource signal so
editors can present their windows without stealing focus.
Comment 1 José Aliste 2010-10-16 20:23:11 UTC 
Created attachment 172508 [details] [review]
[shell] Add timestamp to SyncSource DBUS signal.
Comment 2 José Aliste 2010-10-16 20:23:54 UTC 
Created attachment 172509 [details] [review]
[libview] Add timestamp to SyncSource signal.
Comment 3 Christian Persch 2010-10-17 11:08:37 UTC 
@@ -6611,7 +6612,8 @@ ev_window_sync_source (EvWindow     *window,
 				       g_variant_new ("(s(ii))",
 						      link->filename,
 						      link->line,
-						      link->col),
+						      link->col,
+						      timestamp),

Need to change the signature too: "(s(ii)u)".

Not sure we need to change the internal signal; after all you can use gtk_get_current_event_time ()...
Comment 4 José Aliste 2010-10-17 15:11:48 UTC 
Created attachment 172546 [details] [review]
[shell] add timestamp to SyncSource DBus signal.
Comment 5 Carlos Garcia Campos 2010-11-14 16:38:38 UTC 
Review of attachment 172546 [details] [review]:

I had forgotten this patch, sorry, please push it.