After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632155 - meta_display_get_keybinding_action: remove keysym parameter
meta_display_get_keybinding_action: remove keysym parameter
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-14 15:28 UTC by Dan Winship
Modified: 2010-10-25 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meta_display_get_keybinding_action: remove keysym parameter (2.70 KB, patch)
2010-10-14 15:28 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2010-10-14 15:28:28 UTC
meta_display_process_key_event() always looks up events based on the
"default" keysym for the keycode, so we should do the same here. This
fixes, eg, the lookup of Shift-Alt-Tab (which would otherwise be
unrecognized because the keysym would be XK_ISO_Left_Tab rather than
XK_Tab).
Comment 1 Dan Winship 2010-10-14 15:28:29 UTC
Created attachment 172362 [details] [review]
meta_display_get_keybinding_action: remove keysym parameter
Comment 2 Owen Taylor 2010-10-25 18:06:17 UTC
Review of attachment 172362 [details] [review]:

OK
Comment 3 Dan Winship 2010-10-25 20:38:31 UTC
Attachment 172362 [details] pushed as 03578b6 - meta_display_get_keybinding_action: remove keysym parameter