After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 632040 - perl-Cairo test suite fails with cairo 1.10
perl-Cairo test suite fails with cairo 1.10
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Cairo
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-10-13 09:48 UTC by Vincent Untz
Modified: 2011-04-30 13:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
small patch in order to let the three test cases pass... (1.34 KB, patch)
2011-03-05 08:36 UTC, Raymond
none Details | Review

Description Vincent Untz 2010-10-13 09:48:23 UTC
Apparently, distros need to work around the issue with patches like this one:

http://launchpadlibrarian.net/56312946/libcairo-perl_1.070-1ubuntu1.debdiff
Comment 1 Dominic Hargreaves 2011-02-26 13:47:03 UTC
I can confirm that Debian is also affected by this:
<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613190>. In all likelihood this just needs the test suite updating to reflect changes in the behaviour of Cairo, but it's not obvious to a non-Cairo user what this might be. Incidentally, the same bug has been reported at
<https://rt.cpan.org/Ticket/Display.html?id=62603>.
Comment 2 Raymond 2011-03-05 08:36:20 UTC
Created attachment 182536 [details] [review]
small patch in order to let the three test cases pass...
Comment 3 Raymond 2011-03-05 08:39:49 UTC
Hello,

It is possible to pass these 3 failing tests without disabling them, by
creating an extra surface that actually permits you to create
'color-alpha' surfaces with the `create_similar` sub.

At line 26 of t/CairoSurface.t, an 'rgb24' surface is created.
It seems (to me) that it is not possible anymore to create a
'color-alpha' surface from such an 'rgb24' surface with the
`create_similar` sub with the newest Cairo. I don't know if this
is intended behavior or not.

'argb32' surfaces seem to permit you to `create_similar`
surfaces in both 'color-alpha' or 'color' content.

The original test cases and these altered test cases also emit a
(non-fatal) warning: unknown surface type 16 encountered at
t/CairoSurface.t .. I don't know why (yet),

Perhaps this is useful,

Greetings,

Raymond.
Comment 4 Dominic Hargreaves 2011-04-20 21:32:12 UTC
Hello, are there any Cairo experts able to look at this issue, and perhaps review Raymond's patch?

Thanks,
Dominic.
Comment 5 Torsten Schoenfeld 2011-04-30 13:48:37 UTC
The issue was actually caused by a premature call to $surf->finish.  Fixed in
stable-1-06 and master:
<http://git.gnome.org/browse/perl-Cairo/commit/?h=stable-1-06&id=9073da824de8>.