GNOME Bugzilla – Bug 631887
Fix build against Gtk+ current git version.
Last modified: 2011-02-03 15:30:12 UTC
gdk_drawable_get_display() dissapeared in Gtk+ 2.91. Use new function and add compatibility hack for building with older Gtk+ versions. While at it, restore 2.20 compatibility broken in a previous commit. Bumping required Gtk+ version in configure.in would be another option, but it felt like there wasn't too much need for the big bump of 2.20 -> 2.91 right now.
Created attachment 172101 [details] [review] Add Gtk+ 2.20 compatibility hack for GDK key names "Use new GDK key names" fixed build against Gtk3, but the change is only supported on Gtk+ >= 2.22 and soundjuicer only requires 2.20.
Created attachment 172102 [details] [review] Fix build with Gtk+ 2.91 gdk_drawable_get_display was removed, we need to use the new function gdk_window_get_display to build with Gtk+ >= 2.91.x. The new function is only available since Gtk+ 2.24 and 2.91.0, so we add a compability hack to define it if we're using older Gtk+s (including 2.90.x).
Comment on attachment 172101 [details] [review] Add Gtk+ 2.20 compatibility hack for GDK key names Obsolete since 2.90 is now required in http://git.gnome.org/browse/sound-juicer/commit/?id=83398a1e2d1f1045353884b44c681e035b561023
Comment on attachment 172102 [details] [review] Fix build with Gtk+ 2.91 Onsolete since http://git.gnome.org/browse/sound-juicer/commit/?id=f23bb0a5aac613c385272ee448afd27ce50b9ee4
This has been fixed in the meantime as mentioned in the obsolete messages for the attached patches.