After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631737 - require libnotify version 0.6.0
require libnotify version 0.6.0
Status: RESOLVED FIXED
Product: zenity
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Zenity Maintainers
Zenity Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-10-09 09:09 UTC by William Jon McCann
Modified: 2010-11-17 12:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Require libnotify 0.6.1 (9.54 KB, patch)
2010-10-12 04:54 UTC, William Jon McCann
committed Details | Review
Make libnotify optional in zenity installation (6.57 KB, patch)
2010-11-04 19:15 UTC, Arx Cruz
committed Details | Review

Description William Jon McCann 2010-10-09 09:09:27 UTC
We should require the latest libnotify since it has some behavior and API changes.

Along with this..

The GNOME notification servers (gnome-shell and notification-daemon >= 0.6.0)
support notification persistence.  This means that notification bubbles won't
be transient and require backing with a status icon.  We can drop use of status
icons in these cases.

http://live.gnome.org/GnomeShell/Design/Guidelines/MessageTray/Compatibility
Comment 1 William Jon McCann 2010-10-12 04:54:40 UTC
Created attachment 172153 [details] [review]
Require libnotify 0.6.1
Comment 2 Luis Medinas 2010-10-12 09:56:32 UTC
The patch looks good except that i would like to keep libnotify optional. Zenity is used on many situations that the users need to have low depedencies.

Thanks for the patch.
Comment 3 Luis Medinas 2010-10-20 23:09:41 UTC
Review of attachment 172153 [details] [review]:

William i committed this patch for 2.91.1.1 release but i'll keep this open because i want to make 
notifications optional.

Thanks for the patch.
Comment 4 Arx Cruz 2010-11-04 19:15:12 UTC
Created attachment 173842 [details] [review]
Make libnotify optional in zenity installation

Patch to make libnotify optional added ;)
Comment 5 Luis Medinas 2010-11-17 12:21:09 UTC
The patch was commited to git master.

Thanks
Comment 6 Luis Medinas 2010-11-17 12:21:34 UTC
Review of attachment 173842 [details] [review]:

Commited