GNOME Bugzilla – Bug 631710
displays garbage at bottom of image
Last modified: 2011-05-03 16:12:04 UTC
Created attachment 171970 [details] example screenshot of checkboard Eog 2.32.0 may display "garbage" at the bottom of the image under certain conditions: 1. Open a large image. 2. Zoom out 3. Increase the size of the eog window 4. Scroll down I think eog scrolls down further than it should be possible to, and repeats the bottom part of the image, perhaps offset or corrupted slightly.
Created attachment 171973 [details] [review] not a proper fix I think the bug is from git commit http://git.gnome.org/browse/eog/commit/?h=gnome-2-32&id=ceadfd9141867358aea715ea060a2abe18e7846a "Finish making EogScrollView GSEAL-compatible." In the old code, newly calculated page_size, page_increment, step_increment were always set in the adjustment, but after the changes, they are only changed depending on if xofs / yofs has changed. The patch is just to illustrate how reversing that solves the problem.
On further investigation, you don't need to zoom. Basically the scrollbar doesn't work properly after you resize the eog window - if you increase the eog window size, you can scroll off the bottom of the image, if you decrease the eog window size, you can't scroll down when you should be able to.
I'm still failing to reproduce it here, but I see what you mean in comment 1. The only strange thing with that is that although the old code always set the values it only emitted the signal if xofs was changed (as does the new one). Maybe there's been some slight behavioural change in GTK, but I'll need to install an updated GTK version before I can tell.
JFYI, I could reproduce it now. Had a slight mixup in eog versions.
Created attachment 172010 [details] [review] fix for gnome-2-32 and likely master It basically comes down to your proposal, gtk_adjustment_configure is smart enough to only emit the signals that are actually necessary. This works with the current stable eog. I'm holding this back until I could verify against the development version (doesn't build right now due to GTK-API-changes).
Review of attachment 172010 [details] [review]: I can confirm that this patch fixes this issue with eog 2.32.0.
Thanks for confirming, Edward. Pushed to master and gnome-2-32. Problem was not that visible in the development branch as it would just let you scroll too far without showing garbage. commit b21dd56b9437e53b7ba8abdd96942c1871edc02c Author: Felix Riemann <> Date: Sat Oct 9 15:33:37 2010 +0200 Make sure EogScrollView's adjustment values are always correctly set Ensures one can only scroll as far as necessary. If one scrolled to far the images's last line/column was used for padding. Fixes bug 631710. This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
*** Bug 633449 has been marked as a duplicate of this bug. ***
*** Bug 633544 has been marked as a duplicate of this bug. ***
*** Bug 644335 has been marked as a duplicate of this bug. ***
*** Bug 638407 has been marked as a duplicate of this bug. ***
*** Bug 645490 has been marked as a duplicate of this bug. ***
I'm still seeing this bug in eog 3.2.0. I couldn't tell for sure from the final comments if the fix is coming in a version *after* 3.2.0 or if it's supposed to be fixed in 3.2.0. Anyway, yeah, I took a 1024x1024 PNG in eog, maximized window, zoomed to 1:1 ratio, and scrolled down. It reproduced this bug.
There is no version 3.2.0 yet. Please check your version again. It is fixed in versions 2.32.1 and 3.0.0.
Whoops! Yes, I meant 2.32.0. OK, I guess I'll wait until 2.32.1. Also, I confirmed it does this when scrolling horizontally, too, in case it matters now: 1) Open "large" image (an image too large to fit on screen at 1:1 ratio. 2) Zoom to 1:1. 3) Maximize eog window. 4) Scroll either vertically or horizontally to see the image "boundary strip" redrawn repeatedly past the boundary of the image, i.e., the garbage.
(In reply to comment #15) > Whoops! Yes, I meant 2.32.0. OK, I guess I'll wait until 2.32.1. > 2.32.1 is actually out since November, so you might want to check your distribution updates for it. ;) Note, that some distros don't provide a 2.32.1 package of eog but have the fix backported into their 2.32.0 package (Fedora 14 at least). > Also, I confirmed it does this when scrolling horizontally, too, in case it > matters now: The fix is handling this case too. :)