After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 631576 - Use upstream gettext instead the Glib one
Use upstream gettext instead the Glib one
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-10-07 03:27 UTC by Javier Jardón (IRC: jjardon)
Modified: 2011-05-20 13:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use upstream gettext instead the Glib one (1.41 KB, patch)
2010-10-07 03:28 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Use upstream gettext instead the Glib one.v2 (934 bytes, patch)
2010-10-08 03:28 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-10-07 03:27:27 UTC
Glib gettext macros are old and unmaintained. Also, we can use upstream gettext
now without problems.

Patch following
Comment 1 Javier Jardón (IRC: jjardon) 2010-10-07 03:28:18 UTC
Created attachment 171873 [details] [review]
Use upstream gettext instead the Glib one
Comment 2 Javier Jardón (IRC: jjardon) 2010-10-08 03:28:41 UTC
Created attachment 171941 [details] [review]
Use upstream gettext instead the Glib one.v2

Updated patch. It's not needed to call autopoint in autogen.sh; It's already called in gnome-autogen.sh
Comment 3 Dan Winship 2011-05-19 16:31:12 UTC
Comment on attachment 171941 [details] [review]
Use upstream gettext instead the Glib one.v2

i didn't examine this in detail, but i see that the same change has been made in other packages, so it's presumably safe
Comment 4 Javier Jardón (IRC: jjardon) 2011-05-20 13:09:40 UTC
Comment on attachment 171941 [details] [review]
Use upstream gettext instead the Glib one.v2

commit 4c44bb7f52cc2848990abd57928501be96ca8544
Comment 5 Javier Jardón (IRC: jjardon) 2011-05-20 13:19:13 UTC
Thanks for the review Dan